-
Notifications
You must be signed in to change notification settings - Fork 66
add ExpectDo methods #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Any progress on That?? @ideasculptor @ryantate13 |
I'll update the PR so that it is up to date with go-redis:master but I doubt either of us is going to find ourselves with the time to do the full implementation that would be required to get someone to merge this any time soon. This fork serves our needs sufficiently as it is. Check back in a few hours and I should have the PR updated. |
5aebb94
to
358245b
Compare
done |
// or []interface{}{int64(100), int64(200)}
mock.ExpectDo("hkeys", "hkey").SetVal([]interface{}{"100", "200"})
v, err := client.Do(ctx, "hkeys", "hkey").Int64Slice()
t.Log(v, err) |
This looks like what we are missing... Any progress on this ? @monkey92t @ideasculptor |
Neither @ryantate13 nor I works at the company where we did that work any longer, so
whatever progress we made is no longer accessible to us -
unless Ryan has a copy of source code. I don't. But i know we had
something working in the code, so I suspect I got something to work in a
manner that made sense. But I have no recollection of what it was, sorry.
|
Added example implementations for handling Do() with various return types. Needs to be fleshed out with all of the various potential return types and tests, but demonstrates the concept. I may eventually get around to implementing the feature in its entirety, but probably not anytime soon, unfortunately, so this PR exists largely for documentary purposes in the associated issue: #25