DateTime and the different zero values used. #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fredbi
commented
Mar 13, 2025
fredbi
commented
- fixed the documentation for NewDateTime() to state explicitly that it does not yield the zero value. This value is checked against IsUNIXZero().
- introduced a new method MakeDateTime() for users who want a zero value that checks against IsZero().
- fixes NewDateTime returns a unix 0, but IsZero checks for zero time.Time #141
fredbi
force-pushed
the
fix-141-NewDateTime
branch
2 times, most recently
from
b0787c9 to
8bf5233
Compare
youyuanwu
approved these changes
Mar 14, 2025
ccoVeille
reviewed
Mar 14, 2025
fredbi
force-pushed
the
fix-141-NewDateTime
branch
from
8bf5233 to
4d289ef
Compare
|
Thank you @ccoVeille for your valuable comments. I've addressed your points. |
* fixed the documentation for NewDateTime() to state explicitly that it does not yield the zero value. This value is checked against IsUNIXZero(). * introduced a new method MakeDateTime() for users who want a zero value that checks against IsZero(). * fixes go-openapi#141 Signed-off-by: Frederic BIDON <[email protected]>
Signed-off-by: Frederic BIDON <[email protected]>
fredbi
force-pushed
the
fix-141-NewDateTime
branch
from
4d289ef to
88198fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.