Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pathParamEscaped support #230

Closed

Conversation

alswl
Copy link

@alswl alswl commented Nov 26, 2021

Provide a way to control path parmas.

fix #138

@alswl alswl force-pushed the feat/add-path-param-escaped-support branch from c6e5e15 to 229cc10 Compare November 26, 2021 12:38
Signed-off-by: jingchao.djc <[email protected]>
@youyuanwu
Copy link
Member

#138 was marked as won't fix.
openapi v2 does not specify this behavior, so I vote down for this to be merged.
@casualjim thoughts?

@casualjim
Copy link
Member

I think this is a risky change that allows for ambiguity in routes.

It seems that it's not supported, unless I misunderstand the discussions here which is entirely possible:
OAI/OpenAPI-Specification#892
OAI/OpenAPI-Specification#2653

This is an open issue even for the current openapi specifications, so I'm also not in favor for this change.

@alswl
Copy link
Author

alswl commented Nov 28, 2021

Is it possible to provide a feature gate to enable this feature. In real world, some project is using slash in the HTTP router .

@youyuanwu
Copy link
Member

If (when) openapi decides to incorporate this feature, go-openapi can add this support. But for now, please follow up with openapi feature proposals which casualjim linked above.

@alswl alswl closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide raw path params support to runtime/client
3 participants