Skip to content

feat: align Logger interface and rename constructors#11

Merged
aryeko merged 2 commits intomainfrom
agent-3/logging
Feb 5, 2026
Merged

feat: align Logger interface and rename constructors#11
aryeko merged 2 commits intomainfrom
agent-3/logging

Conversation

@aryeko
Copy link
Collaborator

@aryeko aryeko commented Feb 5, 2026

Type

  • feat — New feature
  • fix — Bug fix
  • refactor — Code restructure (no behavior change)
  • docs — Documentation only
  • test — Test coverage
  • chore — Build, CI, tooling
  • perf — Performance improvement

Summary

Align the logging interface with the documented API by switching to ...any, adding Warn, and renaming the slog and nop constructors, with adapters, middleware, tests, and examples updated to match the new signatures.

Changes

  • Align logging.Logger interface to use ...any arguments
  • Add Warn method to Logger interface
  • Rename NewSlogNewSlogLogger, NopNewNopLogger
  • Update all adapters, tests, and examples

Breaking Changes

Logger method signatures now accept ...any and constructor names have changed to NewSlogLogger/NewNopLogger.

Validation

make fmt && make lint && make test

Installing development tools...
Done: All tools installed
gofmt -w .
/Users/aryekogan/go/bin/goimports -w .
/Users/aryekogan/go/bin/golangci-lint run
go test ./...
ok   github.com/aryeko/modkit/modkit/http	(cached)
ok   github.com/aryeko/modkit/modkit/kernel	(cached)
ok   github.com/aryeko/modkit/modkit/logging	(cached)
ok   github.com/aryeko/modkit/modkit/module	(cached)

Checklist

  • Code follows project style (make fmt passes)
  • Linter passes (make lint)
  • Tests pass (make test)
  • Tests added/updated for new functionality
  • Documentation updated (if applicable)
  • Commit messages follow Conventional Commits

Related Issues

Notes

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Warning

Rate limit exceeded

@aryeko has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 57 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch agent-3/logging

Comment @coderabbitai help to get the list of available commands and usage tips.

@aryeko aryeko merged commit 8c4a973 into main Feb 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant