Optimize imports on the fly #1807
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,6 +26,7 @@ | |||
| ) | |||
| public class GoCodeInsightSettings implements PersistentStateComponent<GoCodeInsightSettings> { | |||
| private boolean myShowImportPopup = true; | |||
| private boolean myOptimizeImportsOnTheFly = false; | |||
|
|
||
| @Override | ||
| protected void applyInformationWithProgress() { | ||
| final Runnable runnable = new GoImportOptimizer().processFile(myFile); |
There was a problem hiding this comment.
So are you going to calculate all imports to remove right in EDT? Don't you think it's not really efficient?
auduchinok
force-pushed
the
on_the_fly_optimize
branch
from
ac03825
to
48c6ccf
Compare
auduchinok
force-pushed
the
on_the_fly_optimize
branch
from
48c6ccf
to
3cb5af0
Compare
|
Please update copyrights before merge. |
|
what's status now of this PR? |
|
@nevernet it's open and doesn't work good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.