feat: use pure-go implementation when cgo is disabled #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a pure-go alternative driver whenever CGO_ENABLED=0 Related: go-gorm#93 Fixes: go-gorm#35 Fixes: go-gorm#72 Fixes: go-gorm#77 Fixes: go-gorm#160
aymanbagabas
added a commit
to aymanbagabas/gorm
that referenced
this pull request
Jul 5, 2023
This tests the sqlite with/out CGO, updates the minimum tests go version to 1.18, and adds the latest go version `^1` to the sqlite CI tests. Related: go-gorm/sqlite#161
3 tasks
aymanbagabas
added a commit
to aymanbagabas/gorm
that referenced
this pull request
Jul 5, 2023
This tests the sqlite with/out CGO, updates the minimum tests go version to 1.18, and adds the latest go version `^1` to the sqlite CI tests. Related: go-gorm/sqlite#161
aymanbagabas
added a commit
to aymanbagabas/gorm
that referenced
this pull request
Jul 5, 2023
This tests the sqlite with/out CGO, updates the minimum tests go version to 1.18, and adds the latest go version `^1` to the sqlite CI tests. Related: go-gorm/sqlite#161
Format yaml using prettier Remove go1.17 since modernc.org/sqlite requires at least go1.18
This enables running tests that require CGO like `go test -race` when using pure-go sqlite through passing `-tags pure` build flag
aymanbagabas
added a commit
to aymanbagabas/gorm
that referenced
this pull request
Jul 6, 2023
This tests the sqlite with/out CGO, updates the minimum tests go version to 1.18, and adds the latest go version `^1` to the sqlite CI tests. Related: go-gorm/sqlite#161
aymanbagabas
added a commit
to aymanbagabas/gorm
that referenced
this pull request
Jul 6, 2023
This tests the sqlite with/out CGO, updates the minimum tests go version to 1.18, and adds the latest go version `^1` to the sqlite CI tests. Related: go-gorm/sqlite#161
aymanbagabas
added a commit
to aymanbagabas/gorm
that referenced
this pull request
Jul 6, 2023
This tests the sqlite with/out CGO, updates the minimum tests go version to 1.18, and adds the latest go version `^1` to the sqlite CI tests. Related: go-gorm/sqlite#161
aymanbagabas
added a commit
to aymanbagabas/gorm
that referenced
this pull request
Jul 6, 2023
This tests the sqlite with/out CGO, updates the minimum tests go version to 1.18, and adds the latest go version `^1` to the sqlite CI tests. Related: go-gorm/sqlite#161
aymanbagabas
added a commit
to aymanbagabas/gorm
that referenced
this pull request
Jul 6, 2023
This tests the sqlite with/out CGO, updates the minimum tests go version to 1.18, and adds the latest go version `^1` to the sqlite CI tests. Related: go-gorm/sqlite#161
aymanbagabas
added a commit
to aymanbagabas/gorm
that referenced
this pull request
Jul 6, 2023
This tests the sqlite with/out CGO, updates the minimum tests go version to 1.18, and adds the latest go version `^1` to the sqlite CI tests. Related: go-gorm/sqlite#161
|
DSNs are different between drivers. Having code that behaves silently behaves significantly differently because the C compiler toolchain is not installed is a bad idea, IMO. |
3 tasks
3 tasks
|
In this case, an alternative would be to allow a user to select the implementation with a specific build tag (like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a pure-go alternative driver whenever CGO_ENABLED=0
Related: #93
Fixes: #35
Fixes: #72
Fixes: #77
Fixes: #160
What did this pull request do?
This PR uses a pure-go implementation of SQLite using https://gitlab.com/cznic/sqlite whenever
CGO_ENABLEDis disabled, and uses https://github.com/mattn/go-sqlite3 when CGO is enabled.User Case Description
As shown in #77 #72 #93 #35, sometime CGO is inconvenient.