Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove importing C from conversions.go #97

Closed
wants to merge 1 commit into from

Conversation

hajimehoshi
Copy link
Member

This is one of the steps in order to remove dependency on Cgo on Windows (go-gl/gl#109).

@hajimehoshi
Copy link
Member Author

@dmitshur Could you take a look? Thanks!

@dmitshur
Copy link
Member

dmitshur commented Oct 20, 2018

It's hard for me to know what effect making this change would have, and I'm hesitant to make a change here before knowing the full picture.

Have you already prototyped the entire "drop Cgo" change for Windows, or is this just a beginning?

I'm worried about what happens if the rest of the changes don't work out, and we'll have made this change without going all the way through.

@dmitshur
Copy link
Member

Also, any non-trivial changes to glow make sense to land after we've gained confidence in the generated code works well and we want to keep it.

@hajimehoshi
Copy link
Member Author

Have you already prototyped the entire "drop Cgo" change for Windows, or is this just a beginning?

Sorry but it is just a beginning. I'm 90% sure I can do though, and even if it was not possible, I thought removing Cgo dependency as much as possible was always good. But, you are right, we need to confirm that everything works.

I'll make the entire change first, and split them into chunks. Thank you for your advice.

@hajimehoshi hajimehoshi deleted the nocgo branch October 20, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants