Reordered null at the end of strings for clarity. #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues just following the code when it comes to null termination. Usually in go you don't deal with worrying about strings having them, so I reordered it such that the null is added inside the
compileShadercode rather than it already existing on the strings.I'm creating this PR as in my opinion it is much clearer at a glance that this is neccesary, as some people (like me) will skip over the addition on the shader sources and would pay closer attention to the compileShader function, assuming the input string is standard & hasn't been doctored beforehand to deal with the idiosyncrasies of needing to worry about null at the end of strings.