Skip to content

Fix #35763: Add proper page title for project pages #35773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #35763: Add proper page title for project pages #35773

wants to merge 1 commit into from
+1 −0

Conversation

@mithileshgupta12
Copy link

@mithileshgupta12 mithileshgupta12 commented Oct 29, 2025 •
edited
Loading

No description provided.

@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 29, 2025
@mithileshgupta12 mithileshgupta12 mentioned this pull request Oct 29, 2025
Open
@silverwind
Copy link
Member

silverwind commented Oct 29, 2025 •
edited
Loading

@wxiaoguang should this use PageTitleCommon added in https://github.com/go-gitea/gitea/pull/35772/files? I wonder why its not named PageTitle.

@wxiaoguang
Copy link
Contributor

I wonder why its not named PageTitle.

PageTitle conflicts with Title when reading

@wxiaoguang
Copy link
Contributor

should this use PageTitleCommon added in https://github.com/go-gitea/gitea/pull/35772/files?

I think the current code is good enough. PageTitleCommon is a suffix when Title exists.

wxiaoguang
wxiaoguang reviewed Oct 29, 2025
View reviewed changes
routers/web/org/projects.go Outdated
ctx.Data["Project"] = project
ctx.Data["IssuesMap"] = issuesMap
ctx.Data["Columns"] = columns
ctx.Data["Title"] = fmt.Sprintf("%s - %s", project.Title, ctx.Org.Organization.DisplayName())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will panic if the project is not in an org?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wxiaoguang I added a check to ensure the project is in organisation. That will make sure that it will not panic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you still need to support setting the title for user repos.

Copy link
Author

@mithileshgupta12 mithileshgupta12 Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do that as well

Copy link
Author

@mithileshgupta12 mithileshgupta12 Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silverwind I fixed the code. Now it handles both user projects and org projects.

Just to clarify the final implementation:

I'm now using ctx.ContextUser.DisplayName() which handles both cases:

  • For organization projects: ContextUser refers to the organization
  • For user projects: ContextUser refers to the individual user

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 29, 2025
@mithileshgupta12 mithileshgupta12 force-pushed the fix/35763-project-page-title branch from fbf3e17 to 43a30b6 Compare October 30, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silverwind silverwind silverwind left review comments

@wxiaoguang wxiaoguang wxiaoguang left review comments

Assignees

No one assigned

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mithileshgupta12 @silverwind @wxiaoguang @GiteaBot