update labeller to include tools folder

[techknowlogick]

No description provided.

[wxiaoguang]

1. Who are using all these labels and how they are used? For example: this PR has modifies/internal, is such label used somewhere?
2. tools/package.json isn't really related to Gitea's dependency?

[techknowlogick]

I use the labels as a signal about what might be included in the PR, and what changes are made. Also, it helps detect changes to PRs that might be unrelated to the PR scope.

[wxiaoguang]

TBH some labels seem noise to me, for example: "api" (a lot of unrelated), "cli" (a lot of unrelated), "internal" (unclear what it is for), "go" (most PRs change go files), "frontend" (tmpl also has frontend layout)

And why this PR has "docs" label.

[denyskon]

I find the system really useful, it allows to filter PRs when reviewing and also to detect a scope of a PRs, for exmple how many different sections they change. It's a difference in my review approach if I see am small CSS change or a PR which modifies go, templates and assets.

[denyskon]

Of for example if I see a PR with modifies/migration I know directly that oops I shouldn't be approving it because I'm not that experienced with migrations

[wxiaoguang]

Of for example if I see a PR with modifies/migration I know directly that oops I shouldn't be approving it because I'm not that experienced with migrations

Then why this PR has "docs" label?

Why "tools" directory affects Gitea's dependencies? None of these libraries in "tools" directory would go into Gitea's build.

[denyskon]

I think build dependencies still count as dependencies

And labels document the PRs, so I think them being part of "docs" is fine.

[techknowlogick]

I think build dependencies still count as dependencies

And labels document the PRs, so I think them being part of "docs" is fine.

Yup, this was my thinking on it too

[wxiaoguang]

I think build dependencies still count as dependencies
And labels document the PRs, so I think them being part of "docs" is fine.

Yup, this was my thinking on it too

TBH I don't agree.

And I don't understand if you agree, then why not make "docs" label be automatically added when such file changes?

[silverwind]

I will probably eliminate tools/package.json by replacing fabric with https://github.com/ssssota/svg2png-wasm. It being wasm means there are no native dependencies, so it will be safe to ship in the main package.json.

The fabric dependency is only used for generating these png images and users who want to build their own images for their instance are running this as well.

Edit: package above is deprecated on npm, so https://github.com/thx/resvg-js#webassembly appears to be the next best thing.

[silverwind]

TBH some labels seem noise to me, for example: "api" (a lot of unrelated), "cli" (a lot of unrelated), "internal" (unclear what it is for), "go" (most PRs change go files), "frontend" (tmpl also has frontend layout)

-modifies/internal is unclear, yes. Would remove it
-modifies/frontend: I would split into modifies/js and modifies/css
-modifies/go: imho keep it
-modifies/api: might be a good indicator to ensure we check for breaking changes
-modifies/cli: no real opinion from me here

[wxiaoguang]

• API: https://github.com/go-gitea/gitea/pulls?q=is%3Apr+label%3Amodifies%2Fapi+is%3Aclosed
• CLI: https://github.com/go-gitea/gitea/pulls?q=is%3Apr+label%3Amodifies%2Fcli+is%3Aclosed

It seems that many (IMO at least half of them) are not really related to the labels (shouldn't be reviewed from the label's perspective). And even without "api" label (no indicator), we should always pay attention to the breakings for every PR.

[silverwind]

Big refactors will always have all labels, it's unavoidable. I guess I agree to removing cli as well if its not helpful.

[techknowlogick]

Closing this due to the wasm PR that would make it unnecessary