Skip to content

Conversation

junoberryferry
Copy link
Contributor

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 31, 2025
Signed-off-by: techknowlogick <[email protected]>
Signed-off-by: techknowlogick <[email protected]>
Signed-off-by: techknowlogick <[email protected]>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 2, 2025
Signed-off-by: techknowlogick <[email protected]>
@techknowlogick
Copy link
Member

@junoberryferry I'm sorry for all the notifications. I've just resolved the linting errors on my phone. Thanks for this PR!

Signed-off-by: techknowlogick <[email protected]>
@lunny
Copy link
Member

lunny commented Sep 3, 2025

Since it's not enabled by default. GOEXPERIMENT=jsonv2 is needed. I don't think this should be merged into v1.25

Signed-off-by: techknowlogick <[email protected]>
@techknowlogick
Copy link
Member

@lunny this PR allows for jsonv2 to be enabled by default once swagger/go issues are solved. We have other optional tags as well, and this could be one of them for those who want to build the binary with the experimental library.

@techknowlogick
Copy link
Member

go-swagger has been updated to resolve the 1.25.0 issues and I updated the makfile to target that commit as a tagged release isn't available yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/dependencies modifies/go Pull requests that update Go code modifies/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants