Only hide dropzone when no files have been uploaded #35156
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
techknowlogick
added
type/bug
topic/ui
blender-it
pushed a commit
to blender/gitea
that referenced
this pull request
Jul 24, 2025
wxiaoguang
reviewed
Jul 25, 2025
blender-it
pushed a commit
to blender/gitea
that referenced
this pull request
Jul 25, 2025
wxiaoguang
reviewed
Jul 25, 2025
wxiaoguang
reviewed
Jul 25, 2025
Signed-off-by: wxiaoguang <[email protected]>
Signed-off-by: wxiaoguang <[email protected]>
wxiaoguang
reviewed
Jul 25, 2025
Signed-off-by: wxiaoguang <[email protected]>
wxiaoguang
reviewed
Jul 25, 2025
Signed-off-by: wxiaoguang <[email protected]>
wxiaoguang
reviewed
Jul 25, 2025
There was a problem hiding this comment.
Made some changes via GitHub online editor.
I think we do not need to tolerate "null/undefined" for this case: if ".form-field-dropzone" exists, then ".dropzone" must exists, then "el.dropzone" must exist. If any of them doesn't exist, there must be something (more serious) wrong.
|
Yeah, it's better to let the code crash than to hide bugs with |
Are there any changes that still need to be made here? |
wxiaoguang
approved these changes
Jul 26, 2025
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Jul 26, 2025
GiteaBot
added
lgtm/done
delvh
approved these changes
Jul 26, 2025
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jul 27, 2025
Instead of always hiding the dropzone when it's not active: - hide it when when there are no uploaded files and it becomes inactive - don't hide it when there are uploaded files Fixes go-gitea#35125 --------- Co-authored-by: wxiaoguang <[email protected]>
lafriks
pushed a commit
that referenced
this pull request
Jul 27, 2025
Backport #35156 by @bartvdbraak Instead of always hiding the dropzone when it's not active: - hide it when when there are no uploaded files and it becomes inactive - don't hide it when there are uploaded files Fixes #35125 Co-authored-by: Bart van der Braak <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 28, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix migrate input box bug (go-gitea#35166) [skip ci] Updated translations via Crowdin Only hide dropzone when no files have been uploaded (go-gitea#35156) Change some columns from text to longtext and fix column wrong type caused by xorm (go-gitea#35141) [skip ci] Updated translations via Crowdin Add `owner` and `parent` fields clarification to docs (go-gitea#35023) Improve language in en-US locale strings (go-gitea#35124)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always hiding the dropzone when it's not active:
Fixes #35125