Fix form property assignment edge case #35073
Merged
+27
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-form-property
branch
from
ab51bc1 to
8430313
Compare
silverwind
reviewed
Jul 14, 2025
| setAttribute: (name: string, value: string) => void; | ||
| } & Record<string, any> | ||
|
|
||
| export function assignElementProperty(el: ElementWithAssignableProperties, kebabName: string, val: string) { |
There was a problem hiding this comment.
Why not Element or HTMLElement?
There was a problem hiding this comment.
Because it needs "any":
There was a problem hiding this comment.
Shouldn't keyof typeof Element work for the property access?
const camelizedName: keyof typeof Element = camelize(kebabName);There was a problem hiding this comment.
If not, use (el as any)[camelizedName] = ... to assign. Better do dirty stuff within a function than to expose any to consumers.
There was a problem hiding this comment.
I don't see a clearer solution.
Feel free to edit this PR directly with your solution.
delvh
approved these changes
Jul 14, 2025
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Jul 14, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jul 15, 2025
"form" has an edge case: its `<input name=action>` element overwrites the `action` property, we can only set attribute. This PR makes `assignElementProperty` can handle such case, and add more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"form" has an edge case: its
<input name=action>element overwrites theactionproperty, we can only set attribute.This PR makes
assignElementPropertycan handle such case, and add more tests