Fix ghost user in feeds when pushing in an actions, it should be gitea-actions #34703
+14
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/templates
delvh
approved these changes
Jun 17, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Jun 17, 2025
| if author != nil { | ||
| emailToUser[sig.Email] = author | ||
| } | ||
| } |
There was a problem hiding this comment.
Why deleted? Pusher doesn't mean committer.
There was a problem hiding this comment.
The original logic used author as pusher which is not right.
wxiaoguang
approved these changes
Jun 17, 2025
GiteaBot
added
lgtm/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #34688
This PR will store the
publisher_idofrelease(tag) table as pusher's id. It could be a real userID or a system user id. If the user is deleted, ghost will be replaced.This PR will also correct the wrong user
Ghostin the feeds and wrong committer on tag list page if pushing a tag from an actions. Now the behavior is the same as Github. Some codes are deleted because it tries to get commit author as pusher which is not right.