Fix incorrect divergence cache after switching default branch #34370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
Issue: After switching the default branch, other branches are still compared against the old default branch due to outdated divergence cache. Change: Clear the divergence cache in SetRepoDefaultBranch to ensure correct comparisons against the new default branch. Fixes go-gitea#34369
GWDx
force-pushed
the
fix-branch-divergence
branch
from
aec8d9b to
9902c62
Compare
lunny
approved these changes
May 5, 2025
GiteaBot
added
lgtm/need 1
|
It's better to have a test. |
Verify that branch divergence counts are correctly recalculated after changing the default branch.
|
I’ve added an integration test to verify that branch divergence counts are correctly recalculated after switching the default branch. |
silverwind
reviewed
May 7, 2025
|
|
||
| htmlDoc := NewHTMLParser(t, resp.Body) | ||
|
|
||
| branchNodes := htmlDoc.doc.Find(".gt-ellipsis").Nodes |
There was a problem hiding this comment.
This class selector is too unspecific. Can you maybe add a new unique class to the elements in question and select on that?
There was a problem hiding this comment.
I added a new .branch-name class to branch name elements in the branch list template, and updated integration test accordingly.
There was a problem hiding this comment.
I added a new
.branch-nameclass to branch name elements in the branch list template, and updated integration test accordingly.
I suggest left a comment like something that branch-name is used for tests, do not remove.
There was a problem hiding this comment.
I suggest left a comment like something that branch-name is used for tests, do not remove.
Not strictly needed imho, but nice to have because one will notice anyways when the test starts to fail.
github-actions
bot
added
the
modifies/templates
yp05327
approved these changes
May 8, 2025
GiteaBot
added
lgtm/done
silverwind
approved these changes
May 8, 2025
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 8, 2025
…ea#34370) Issue: After switching the default branch, other branches are still compared against the old default branch due to outdated divergence cache. Change: Clear the divergence cache in SetRepoDefaultBranch to ensure correct comparisons against the new default branch. Fixes go-gitea#34369
GiteaBot
added
backport/done
silverwind
pushed a commit
that referenced
this pull request
May 8, 2025
#34406) Backport #34370 by @GWDx Issue: After switching the default branch, other branches are still compared against the old default branch due to outdated divergence cache. Change: Clear the divergence cache in SetRepoDefaultBranch to ensure correct comparisons against the new default branch. Fixes #34369 Co-authored-by: GWDx <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 9, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix autofocus behavior (go-gitea#34397) Fix incorrect divergence cache after switching default branch (go-gitea#34370) Add a button editing action secret (go-gitea#34348) Fix LFS file not stored in LFS when uploaded/edited via API or web UI (go-gitea#34367) [skip ci] Updated translations via Crowdin Fix "The sidebar of the repository file list does not have a fixed height go-gitea#34298" (go-gitea#34321) feat: add label 'state' to metric 'gitea_users' (go-gitea#34326) Update JS and PY dependencies (go-gitea#34391) Upgrade go-github v61 -> v71 (go-gitea#34385) Bump `@github/relative-time-element` to v4.4.7 (go-gitea#34384) gitignore: Visual Studio settings folder (go-gitea#34375) Grey out expired artifact on Artifacts list (go-gitea#34314)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: After switching the default branch, other branches are still compared against the old default branch due to outdated divergence cache.
Change: Clear the divergence cache in SetRepoDefaultBranch to ensure correct comparisons against the new default branch.
Fixes #34369