Refactor Branch struct in package modules/git #33980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
modifies/api
lunny
changed the title
pull-request-size
bot
added
size/L
lunny
commented
Mar 23, 2025
| @@ -169,13 +169,6 @@ func ToAPIPullRequest(ctx context.Context, pr *issues_model.PullRequest, doer *u | |||
| } | |||
|
|
|||
| if pr.Flow == issues_model.PullRequestFlowAGit { | |||
| gitRepo, err := gitrepo.OpenRepository(ctx, pr.BaseRepo) | |||
There was a problem hiding this comment.
Line 146 has created gitRepo.
lunny
force-pushed
the
lunny/remove_unnecessary_repo_branch
branch
from
d537b13 to
c46d935
Compare
yp05327
reviewed
Mar 25, 2025
yp05327
reviewed
Mar 25, 2025
yp05327
reviewed
Mar 25, 2025
lunny
force-pushed
the
lunny/remove_unnecessary_repo_branch
branch
from
c352d62 to
e5f8538
Compare
hiifong
approved these changes
Apr 1, 2025
GiteaBot
added
lgtm/need 1
yp05327
approved these changes
Apr 2, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 3, 2025
* giteaofficial/main: Refactor Branch struct in package modules/git (go-gitea#33980) Support creating relative link to raw path in markdown (go-gitea#34105) Add new CLI flags to set name and scopes when creating a user with access token (go-gitea#34080) Do not show 500 error when default branch doesn't exist (go-gitea#34096) Return default avatar url when user id is zero rather than updating database (go-gitea#34094) [skip ci] Updated translations via Crowdin Fix return bug (go-gitea#34093) Move ParseCommitWithSSHSignature to service layer (go-gitea#34087) fix(i18n): clarify ownership in password change error messages (go-gitea#34092) Enable addtional linters (go-gitea#34085) Add flat-square action badge style (go-gitea#34062) Fix some UI bugs and clean up unused tests (go-gitea#34088)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Branchstruct inmodules/gitpackage is unnecessary. We can just use astringto represent a branch