livedns: add a resource to manipulate domain keys #92
Conversation
vincentbernat
force-pushed
the
feature/livedns-key
branch
2 times, most recently
from
3b0fa1c to
e33f849
Compare
|
I would prefer to postpone this after the release. |
|
No problem, as this also requires a new release of go-gandi to be useful. |
vincentbernat
force-pushed
the
feature/livedns-key
branch
3 times, most recently
from
69dd4ff to
f18b311
Compare
|
I have updated this PR and bumped go-gandi dependency. |
|
I think this PR is ready for merge now that we have a release. Also, how about hosting the Pulumi provider under go-gandi? Since I am using both LiveDNS and domains, I think I can maintain it for Python and Go. |
|
@vincentbernat why not :-) I'll welcome any contribution. I started go-gandi and the terraform provider as a small personal side-project, it is now well beyond my scope. If you are okay to be identified as the main (and maybe only, for now) maintainer for the Pulumi provider, I'm completely okay to have it in this group! |
|
Yes, I am OK with that. The goal is just to have something a bit more official in term of namespace. I don't intend to spend a lot of time on it, but I can fix bugs and keep it in sync with the terraform provider. I don't intend to push it to the Pulumi registry yet, I'll see if there are other users first. |
|
@vincentbernat I have invited you to the team. After you accept the invitation, you should be able to create & transfer repositories. |
| last = keys[len(keys)-1].UUID | ||
| } | ||
|
|
||
| _, err = client.SignDomain(domain) |
There was a problem hiding this comment.
I think you should be able to get the resource UUID by using the Location response header such as in https://github.com/go-gandi/go-gandi/blob/8ada87e22651f84dc33b6365f0d1dcad5c483e45/simplehosting/simplehosting.go#L48
There was a problem hiding this comment.
Thanks! I'll do that!
🎉 Welcome aboard 🎉 Regarding the Pulumi repository, would you accept to add something such as Also, you could submit your pulumi project in the awesome-gandi repository if you want to make it more visible ;) |
|
I am running a bit short on time currently, but fear not, I have not forgotten! |
vincentbernat
force-pushed
the
feature/livedns-key
branch
from
f18b311 to
874eaf0
Compare
|
I have rebased this PR. It should be ready now. As for the Pulumi provider, since @rawkode already pushed its version to pulumiverse, I prefer to use it instead of my "own" (that's really just a thin wrapper). |
vincentbernat
force-pushed
the
feature/livedns-key
branch
from
874eaf0 to
568285f
Compare
There are one important shortcoming with this implementation: - When creating a key, the API does not return its UUID. We guess the UUID to be the last one, but this is quite a wild guest. Gandi should provide the UUID in the return of the API call. I didn't generate the documentation as I expect this to be done prior to releasing.
vincentbernat
force-pushed
the
feature/livedns-key
branch
from
568285f to
5f783bc
Compare
There are two important shortcomings with this implementation:
When creating a key, the API does not return its UUID. We guess the
UUID to be the last one, but this is quite a wild guest. Gandi
should provide the UUID in the return of the API call.
go-gandi does not return the public key when asking for the keyassociated to a domain. This makes it impossible to register the
key properly with the Domain API.
See GetDomainKey should provide public key go-gandi#55
Also, I didn't generate the documentation as I expect this to be done
prior to releasing.