Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Personal Access Tokens #148

Closed
wants to merge 2 commits into from

Conversation

nautik1
Copy link
Contributor

@nautik1 nautik1 commented Dec 19, 2023

Personal Access Tokens support was added in go-gandi 0.7.0, would be nice to switch to using them in this provider

This MR is based on this other one so that CI can work well

gandi/provider.go Show resolved Hide resolved
gandi/provider.go Show resolved Hide resolved
@nlewo
Copy link
Member

nlewo commented Jan 2, 2024

Hi @nautik1
Thanks for your contribution!

Note i need to check how to make the CI working with PAT: since this branch is not part of this repo, the acceptance test is not executed (to avoid leaking repository secrets).

@nlewo nlewo mentioned this pull request Jan 4, 2024
@nautik1 nautik1 force-pushed the support-pat branch 2 times, most recently from 12c6e16 to 0ef3aed Compare January 4, 2024 17:02
@nlewo
Copy link
Member

nlewo commented Jan 5, 2024

@nautik1 This has been integrated by #151 (in order to be tested)

Thank you!

@nlewo nlewo closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants