Add support for ZeroSSL account registration #1501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i would also like this feature. i've actually rebased this patch and am using it already for myself. |
3 tasks
fln
force-pushed
the
master
branch
2 times, most recently
from
ac07802
to
f17568a
Compare
This commit extends lego library and cli tool to support issuing certificates from ZeroSSL without having to manually create an account. Without this commit ZeroSSL can be used but users need to manually create ZeroSSL account and start `lego` in EAB (External Account Binding) mode. From the `lego` cli tool perspective this commit: Detects if `lego` ir running with ZeroSSL ACME directory `--server https://acme.zerossl.com/v2/DV90` and uses ZeroSSL API to issue keys for EAB. There is no need to provide `--eab`, `--kid`, `--hmac` values anymore. From the library perspective this commit: Creates new method `RegisterWithZeroSSL()` in the `registration` package which takes care of creating ZeroSSL account with a given email. Internally it re-uses `RegisterWithExternalAccountBinding()` method after KID and HMAC are retrieved from ZeroSSL registration endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends lego library and cli tool to support issuing
certificates from ZeroSSL without having to manually create an account.
Without this commit ZeroSSL can be used but users need to manually
create ZeroSSL account and start
legoin EAB (External AccountBinding) mode.
From the
legocli tool perspective this commit:Detects if
legoir running with ZeroSSL ACME directory--server https://acme.zerossl.com/v2/DV90and uses ZeroSSL API to issue keys forEAB. There is no need to provide
--eab,--kid,--hmacvaluesanymore.
From the library perspective this commit:
Creates new method
RegisterWithZeroSSL()in theregistrationpackage which takes care of creating ZeroSSL account with a given email.
Internally it re-uses
RegisterWithExternalAccountBinding()methodafter KID and HMAC are retrieved from ZeroSSL registration endpoint.