Repository navigation
CFCharacterSet: fix off-by-one in character range operations - #94
Merged
Merged
Conversation
CFCharacterSetCreateWithCharactersInRange, CFCharacterSetAddCharactersInRange and CFCharacterSetRemoveCharactersInRange passed range.location + range.length to the ICU set functions, whose end bound is inclusive, so each included one extra character. Pass the last index of the range instead, and treat an empty range as empty.
DTW-Thalion
force-pushed
the
fix/cfcharacterset-range
branch
from
July 24, 2026 15:16
1129ff2 to
e891d06
Compare
rfm
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFCharacterSetCreateWithCharactersInRange, CFCharacterSetAddCharactersInRange and
CFCharacterSetRemoveCharactersInRange passed range.location + range.length as the
end bound to uset_open / uset_addRange / uset_removeRange, but those ICU functions
take an inclusive end, so each operation covered one extra character. For example
CFCharacterSetCreateWithCharactersInRange(CFRangeMake(0x1F600, 1)) contained both
U+1F600 and U+1F601. Pass the last index of the range, and treat an empty range as
empty. Verified against Apple CoreFoundation.