Repository navigation
CFString: implement CFStringFindAndReplace - #85
Merged
Merged
Conversation
The function was a stub that returned 0 and changed nothing, which also left CFStringTrim (built on it) inert. Search the range for each match and replace or delete it, returning the number of replacements.
DTW-Thalion
force-pushed
the
fix/cfstring-findandreplace
branch
from
July 24, 2026 15:13
cb962c2 to
626d993
Compare
rfm
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFStringFindAndReplace was a stub that returned 0 and made no change, which also
left CFStringTrim inert since it is implemented with two CFStringFindAndReplace
calls. It now searches the range for each occurrence and replaces it (or deletes
it when the replacement is NULL), returning the number of replacements, so both
CFStringFindAndReplace and CFStringTrim work. Verified against Apple CoreFoundation.