Repository navigation
CFString: honour kCFCompareAnchored in string search - #81
Merged
Merged
Conversation
The search ignored kCFCompareAnchored, so CFStringHasPrefix and CFStringHasSuffix matched a substring anywhere in the string. Reject a match that does not sit at the anchored end of the search range.
DTW-Thalion
force-pushed
the
fix/cfstring-anchored
branch
from
July 24, 2026 15:12
02bcda4 to
3bd54b1
Compare
rfm
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFStringFindWithOptionsAndLocale did not implement kCFCompareAnchored, so the
option was silently ignored. As a result CFStringHasPrefix and CFStringHasSuffix,
which rely on anchoring, returned true for any substring:
CFStringHasPrefix(CFSTR("Hello, World"), CFSTR("World")) was true. The fix rejects
a match that does not begin at the range start (or, with kCFCompareBackwards, end
at the range end). Verified against Apple CoreFoundation.