Repository navigation
CFString: pass comparison operands to the collator in order - #80
Merged
Merged
Conversation
CFStringCompareWithOptionsAndLocale handed the second string to the collator as the source and the first as the target, which inverted every ordered result.
DTW-Thalion
force-pushed
the
fix/cfstring-compare
branch
from
July 24, 2026 15:12
055e51a to
349e368
Compare
Contributor
|
A check failed here. |
With the collator operands passed in order, CFStringCompare now sorts dictionary keys correctly, so the OpenStep writer emits them alphabetically. Update the expected output to match.
fredkiefer
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFStringCompareWithOptionsAndLocale passed the second string to ucol_strcoll as
the source and the first as the target, so every ordered comparison came back
inverted: CFStringCompare(CFSTR("abc"), CFSTR("abd"), 0) returned
kCFCompareGreaterThan, and kCFCompareNumerically ordered "file10" before "file9".
Passing the operands in order restores the documented result. Verified against
Apple CoreFoundation.