Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidity 0.7.1 support #190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solidity 0.7.1 support #190

wants to merge 2 commits into from

Conversation

vporton
Copy link

@vporton vporton commented Dec 10, 2020

Testing does not work:

Error: 
    at Deployer._preFlightCheck (/disk2/porton/Projects/bounties/pm-contracts/node_modules/truffle/build/webpack:/packages/deployer/src/deployment.js:179:1)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at /disk2/porton/Projects/bounties/pm-contracts/node_modules/truffle/build/webpack:/packages/deployer/src/deployment.js:282:1
    at Migration._deploy (/disk2/porton/Projects/bounties/pm-contracts/node_modules/truffle/build/webpack:/packages/migrate/Migration.js:68:1)
    at Migration._load (/disk2/porton/Projects/bounties/pm-contracts/node_modules/truffle/build/webpack:/packages/migrate/Migration.js:55:1)
    at Migration.run (/disk2/porton/Projects/bounties/pm-contracts/node_modules/truffle/build/webpack:/packages/migrate/Migration.js:171:1)
    at Object.runMigrations (/disk2/porton/Projects/bounties/pm-contracts/node_modules/truffle/build/webpack:/packages/migrate/index.js:150:1)
    at Object.runFrom (/disk2/porton/Projects/bounties/pm-contracts/node_modules/truffle/build/webpack:/packages/migrate/index.js:110:1)
    at Object.runAll (/disk2/porton/Projects/bounties/pm-contracts/node_modules/truffle/build/webpack:/packages/migrate/index.js:114:1)
    at Object.run (/disk2/porton/Projects/bounties/pm-contracts/node_modules/truffle/build/webpack:/packages/migrate/index.js:79:1)
    at Object.run (/disk2/porton/Projects/bounties/pm-contracts/node_modules/truffle/build/webpack:/packages/core/lib/testing/Test.js:107:1)
Truffle v5.1.56 (core: 5.1.56)
Node v12.16.2
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Copy link
Contributor

@cag cag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting... I hope this branch is useful for others. I'm not sure whether this would actually get merged and/or published because this version of the code is already kind of cemented on the chain in some sense, but I also guess that this could be useful for people who are trying to talk to the old contracts with the newer Solidity versions. Well, unless their workflow already enables multiple solc versions...

Anyway, conditional tokens are kind of the successor to this set of contracts anyway, so I would consider more the port to 0.7.x there that I think you've posted.

@vporton
Copy link
Author

vporton commented Dec 17, 2020

Anyway, conditional tokens are kind of the successor to this set of contracts anyway, so I would consider more the port to 0.7.x there that I think you've posted.

I did port https://github.com/gnosis/conditional-tokens-contracts to 0.7.1 too: gnosis/conditional-tokens-contracts#111 (not enough tested!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants