-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): add moul/xmath #3403
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Signed-off-by: moul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe we could add a git workflow to check that the generated code in examples is synced?
Signed-off-by: moul <[email protected]>
@n0izn0iz good idea, sholud be good with my last commit. |
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Despite the LGTMs (thank you, guys), I'm waiting for @thehowl's opinion before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long-term, I think we can have a way to generate code using gno; seeing as there is no fs access, I'd imagine something like //gno:generate myGeneratorFunc() > output.gen.gno
. But this is non-trivial and something to be understood later. This can work for now and is useful.
One thing to consider is that .go
files are not currently included in MemPackages (outside of standard libraries, where we want them because of native bindings). It may make sense to start including .go files, as long as we exclude transpiled gno code.
Signed-off-by: moul <[email protected]>
For the long-term gno-powered generation, I have two ideas in mind that I believe I have already started in a draft PR. |
Experimenting with Go-based code generation in the
examples/
folder.