Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add moul/xmath #3403

Merged
merged 11 commits into from
Jan 8, 2025
Merged

feat(examples): add moul/xmath #3403

merged 11 commits into from
Jan 8, 2025

Conversation

moul
Copy link
Member

@moul moul commented Dec 24, 2024

Experimenting with Go-based code generation in the examples/ folder.

@moul moul self-assigned this Dec 24, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 24, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 24, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@moul moul marked this pull request as ready for review December 24, 2024 20:46
@moul moul requested a review from ltzmaxwell December 26, 2024 10:06
@moul moul requested review from thehowl, n0izn0iz and leohhhn December 26, 2024 20:02
Copy link
Contributor

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe we could add a git workflow to check that the generated code in examples is synced?

@moul
Copy link
Member Author

moul commented Dec 28, 2024

@n0izn0iz good idea, sholud be good with my last commit.

Copy link
Contributor

@n2p5 n2p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moul
Copy link
Member Author

moul commented Jan 6, 2025

Despite the LGTMs (thank you, guys), I'm waiting for @thehowl's opinion before merging.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long-term, I think we can have a way to generate code using gno; seeing as there is no fs access, I'd imagine something like //gno:generate myGeneratorFunc() > output.gen.gno. But this is non-trivial and something to be understood later. This can work for now and is useful.

One thing to consider is that .go files are not currently included in MemPackages (outside of standard libraries, where we want them because of native bindings). It may make sense to start including .go files, as long as we exclude transpiled gno code.

Signed-off-by: moul <[email protected]>
@moul
Copy link
Member Author

moul commented Jan 8, 2025

For the long-term gno-powered generation, I have two ideas in mind that I believe I have already started in a draft PR.

@moul moul merged commit fa037e7 into gnolang:master Jan 8, 2025
17 checks passed
@moul moul deleted the dev/moul/xmath branch January 8, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants