-
Notifications
You must be signed in to change notification settings - Fork 39
Added information #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DonutsNL
wants to merge
9
commits into
glpi-project:master
Choose a base branch
from
DonutsNL:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added information #145
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
17cc55c
Update guidelines.rst
DonutsNL 62bfa21
Update guidelines.rst
DonutsNL 9bc04d0
Update guidelines.rst
DonutsNL e014505
Update guidelines.rst
DonutsNL 294fd15
Update guidelines.rst
DonutsNL 011b1a2
Corrected the RST directives and text.
DonutsNL 4a64691
Delete settings.json
DonutsNL a163ac8
Update guidelines.rst
DonutsNL 88864f0
Update guidelines.rst
DonutsNL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire paragraph must be removed if it's indeed related to versions prior to GLPI v10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change currently only adds the label. You want me to drop the paragraph or just accept this change from someone else?
But considering my recent rewrite i think it needs a rewrite for glpi11 as well 😅
In that regard, What are the (structuring) rules regarding documenting for various versions. With GLPI11 alot is changing in regards to the folder structure (dropping marketplace, no more front (if done right), etc)
Should the convention documentation only describe the latest (x) versions, only the supported versions, all versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Developers documentation currently only targets GLPI v11.
Changes made in v11 can be marked with a
.. versionadded:: 11.0.0
or.. versionchanged:: 11.0.0
and v10 info can be kept - if you want.But everything older should just be removed (versions are no longer supported).