Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use app.component instead of mixin for global component registration #317

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Jul 19, 2023

Guess we're moving away from mixins 😎

@kiaking kiaking added the enhancement New feature or request label Jul 19, 2023
@kiaking kiaking self-assigned this Jul 19, 2023
@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 353e210
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/64b77b67cad4650008f66e87
😎 Deploy Preview https://deploy-preview-317--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 353e210
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/64b77b6778c51c0008b60f84
😎 Deploy Preview https://deploy-preview-317--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a70236c) 83.72% compared to head (353e210) 83.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   83.72%   83.72%           
=======================================
  Files         128      128           
  Lines       10614    10614           
  Branches      450      450           
=======================================
  Hits         8887     8887           
  Misses       1727     1727           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiaking kiaking merged commit adbe875 into main Jul 20, 2023
11 checks passed
@kiaking kiaking deleted the refactor-mixin branch July 20, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant