No longer parse identification line #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Any news on this? Would be nice as this library is used by ESPHome and at least in Sweden this patch is needed. |
Just a little nitpicking. It is only needed by some power meters used in Sweden, there are various regional/municipal power grids using different power meters. I am in Sweden and my meter from Vattenfall does not need this as it identification starts with As I wrote in #24 I agree that the check should be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The identification line isn't actually used, and the Vattenfall Warmtelink sends an identifier as
/NWA-WARMTELINK. See also #10, which attempted to do this via regex, and the upstream matthijskooijman@ad23937