Skip to content

Conversation

@zth
Copy link

@zth zth commented Oct 23, 2022

Adding this enables reanalyze to do exception analysis when using rescript-fetch with the upcoming async/await feature in ReScript v10.1.

The exception analysis in question is shown here: https://forum.rescript-lang.org/t/ann-async-await-is-coming-to-rescript/3488/16

@glennsl
Copy link
Owner

glennsl commented Nov 22, 2022

Hi. Thanks for this, and sorry for the slow reply. I'm not that familiar with reanalyze, so I'm a bit confused as to what this actually does though. Is this signifying that fetch can raise an exception immediately, or only that it can do so through a promise, that is then raised when awaited? If the latter, how does it distinguish between immediate exceptions and async exceptions?

Also, why does this only apply to fetch, not get or send which are aliases for fetch, or even other async functions such as Response.json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants