improve performance of string.join #822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a similar situation to
string.concat
, however I do not know about a BIF we could use here so the Gleam implementation is actually best.There is also a FFI version for Javascript, but even that is slower than a pure Gleam solution now, most likely due to the recent improvements to list pattern matching in 1.9.
For the benchmark numbers, I chose to join on
,
, since I believe a short character join string is the most common case.Numbers!