Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store a Hex key locally #3900

Merged
merged 10 commits into from
Dec 3, 2024
Merged

Store a Hex key locally #3900

merged 10 commits into from
Dec 3, 2024

Conversation

lpil
Copy link
Member

@lpil lpil commented Nov 26, 2024

A precursor to #3655

@lpil lpil changed the title gleam hex create-key Store a Hex key locally Nov 27, 2024
@lpil lpil marked this pull request as ready for review December 3, 2024 12:03
GearsDatapacks
GearsDatapacks approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@GearsDatapacks GearsDatapacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with the hex API or any of the cli/io code, but it looks good to me!

@lpil lpil merged commit b606364 into main Dec 3, 2024
12 checks passed
@lpil lpil deleted the hex-auth branch December 3, 2024 13:26
@lpil lpil restored the hex-auth branch December 3, 2024 13:27
@lpil lpil deleted the hex-auth branch December 3, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GearsDatapacks GearsDatapacks GearsDatapacks approved these changes

@giacomocavalieri giacomocavalieri Awaiting requested review from giacomocavalieri

@Acepie Acepie Awaiting requested review from Acepie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpil @GearsDatapacks