Ruby 3 Compatibility + Crawl Data #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add data attribute to crawl! method
…ed some development gems Fixed Ruby 2.7 warning for keyword arguments
|
@glaucocustodio Sorry for the delay in submitting this! Github notifications feel like whispers in a crowd Looks like there's conflicts, which makes sense, and I'm realizing now by having my master branch be the source of the PR for both this repo and the other… submitting changes to my branch isn't going to be the way. We're in advanced git territory now. Hmm |
|
I made a new branch and will resubmit the PR from there |
|
cool, looking forward for your PR, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing data: {} into crawl! from this branch https://github.com/dtengeri/kimuraframework
Ruby 3 compatibility from this branch: https://github.com/n-studio/kimuraframework
Submitting this PR as requested here: vifreefly#70