Add search suggestions feature with separated search engine and suggestion engine. #702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a new handleSearchSuggestionsRequest HTTP handler that:
For example, if
The search bar will use Google's autocompletion API to generate autocompletions for the query.
In the case that Startpage is the search engine, but
suggestion-engine
is defined, thesuggestion-engine
value takes precedence.To be entirely clear:
./glance.go now contains the rough equivalent of a proxy. Its sole purpose is to ignore Startpage's CORS restriction on who can make requests to their suggestion endpoint, this is within their Terms of Use.
This seems like the best solution at the moment, it works very well. I have not yet run into issues regarding rate-limiting, nor do I predict any issues.