Enable unstable-sha256 for git2 - #3001
Conversation
unstable-sha256 for git2
|
@extrawurst I tested this branch locally and was able to open a SHA-256 repository. I’m wondering what amount of testing we want before we want to merge this change. If we wanted, we could run all tests twice, once with SHA-1 and once with SHA-256. This is something we do in That said, though, I’m also fine with not adding much in terms of testing in this PR, knowing that test coverage in |
|
@extrawurst can we do anything to support you with this PR? |
|
@cruessler should be done after fixing conflicts. i am happy to broaden testing through the nightlies then |
|
Thanks for the mention! (I hadn’t noticed that the build was red.) |
|
@cruessler the merge is still conflicting |
|
Thanks again! CI is now green! |
|
@cruessler we should probably add a changelog line for sha256 support, can you do a followup? |
This PR is a follow-up to #2962 and #2967. It enables the
unstable-sha256feature forgit2. This change should enablegituito work with SHA-256 repos since SHA-256 support forgitoxidewas enabled via #2967 already.