Skip to content

Enable unstable-sha256 for git2 - #3001

Merged
extrawurst merged 5 commits into
gitui-org:masterfrom
cruessler:enable-unstable-sha-256-for-git2
Oct 6, 2026
Merged

extrawurst merged 5 commits into
gitui-org:masterfrom
cruessler:enable-unstable-sha-256-for-git2

Conversation

@cruessler

@cruessler cruessler commented Jul 19, 2026 •

Copy link
Copy Markdown
Collaborator

This PR is a follow-up to #2962 and #2967. It enables the unstable-sha256 feature for git2. This change should enable gitui to work with SHA-256 repos since SHA-256 support for gitoxide was enabled via #2967 already.

@cruessler cruessler changed the title enable unstable sha 256 for git2 Enable unstable-sha256 for git2 Jul 19, 2026
@cruessler
cruessler marked this pull request as ready for review July 19, 2026 20:17
@cruessler

Copy link
Copy Markdown
Collaborator Author

@extrawurst I tested this branch locally and was able to open a SHA-256 repository. I’m wondering what amount of testing we want before we want to merge this change. If we wanted, we could run all tests twice, once with SHA-1 and once with SHA-256. This is something we do in gitoxide for the large majority of tests. gix-testtools, in particular, has support for both hashes, so we could also add gix-testtools as a dependency.

That said, though, I’m also fine with not adding much in terms of testing in this PR, knowing that test coverage in gitoxide at least is already quite thorough and assuming the same is true for git2. What do you think?

@georglauterbach

Copy link
Copy Markdown

@extrawurst can we do anything to support you with this PR?

@extrawurst

Copy link
Copy Markdown
Collaborator

@cruessler should be done after fixing conflicts. i am happy to broaden testing through the nightlies then

@cruessler

Copy link
Copy Markdown
Collaborator Author

Thanks for the mention! (I hadn’t noticed that the build was red.)

@extrawurst

Copy link
Copy Markdown
Collaborator

@cruessler the merge is still conflicting

@cruessler

Copy link
Copy Markdown
Collaborator Author

Thanks again! CI is now green!

@extrawurst
extrawurst merged commit d7214ec into gitui-org:master Oct 6, 2026
22 checks passed
@extrawurst

extrawurst commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

@cruessler we should probably add a changelog line for sha256 support, can you do a followup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants