Support options in git_status.fetch()

[kanielrkirby]

It looks like support was available/built-in, but possibly left out for some reason?

Happy to rework, this is just to start conversations :)

This Pull Request fixes/closes #2263.

I followed the checklist:

• I added unittests
• I ran make check without errors
• I tested the overall application
• I added an appropriate item to the changelog

It would also be good to know your stance on the ? idea, or any other additions you might want to this to make this mergeable.

[kanielrkirby]

I just realized I got it backwards! That is totally my bad 😅

[extrawurst]

thanks for looking into this. i wonder what blame tells us how this got overseen - I assume no one ever used it so it went unnoticed 🙈

[kanielrkirby]

thanks for looking into this. i wonder what blame tells us how this got overseen - I assume no one ever used it so it went unnoticed 🙈

It seems to be, it's been 3 years! To be completely fair, most people (myself included) don't know how Git works in most cases. All you usually need is the good ol' clone <repo>; add <things>; commit -m <changes>; push;

I remember seeing this was from Stephan Dilly (though I'm not sure who that is, he's in a lot of the old code. Is that your old handle / name perhaps? Or an old maintainer?)

After blaming (using the recursive blame I just added! haHA!!), the project at that point was (as far as I can tell) fully able to support it (the options were there already). Maybe it was just planned to be done in a separate commit.

[ondrej-ivanko]

I'm glad someone is working on this. Thank you guys. I use stashing a lot, so this would definitely help me.

I suppose this solution doesn't really change anything in the functionality, when user swaps different values in Options -> Status -> Show untracked on Stash tab [4]. In my case switching to different values in the Show untracked option doesn't change what files are displayed on Stash tab [4], only what files are displayed on Status tab [1].

[naseschwarz]

Hi!

I've noticed a minor snag with the --keep-index logic in your PR.

If you were to fix that and please add an entry to CHANGELOG.md, I'd say we're good to go, though.

[naseschwarz]

My expectation here would be, that this file list shows all those files, which would be included in a stash.

Here's --keep-index's description:

      -k, --keep-index, --no-keep-index
           This option is only valid for push and save commands.

           All changes already added to the index are left intact.

I.e. "keep index" has no effect on whether a change in the index is stashed or not. It just affects whether that change is removed from the index and work tree afterwards.

Thus, I would have expected that whether "keep index" is active or not has no effect on whether that file a file in the index is listed here.

[extrawurst]

@kanielrkirby are you committed to help push this over the finish line?