Skip to content

style: refine leaderboard history filters with clear controls#122

Closed
marktech0813 wants to merge 1 commit into
gittensor-agent-forge:mainfrom
marktech0813:fix/106-session-composer-clear
Closed

style: refine leaderboard history filters with clear controls#122
marktech0813 wants to merge 1 commit into
gittensor-agent-forge:mainfrom
marktech0813:fix/106-session-composer-clear

Conversation

@marktech0813

@marktech0813 marktech0813 commented Jul 24, 2026

Copy link
Copy Markdown

Summary

Makes the Resolved PR History filter/search controls recoverable: clear the search field, reset all filters in one click, and show a contextual empty state when a filter returns no matches.

Contribution Type

  • Leaderboard UI

Motivation

Once a reviewer types a search or picks a non-All filter that yields zero rows, the archive looks empty with no obvious way back. The prior empty copy always said "No Resolved PRs", which is misleading when the archive has entries that simply don't match the active controls.

This PR was originally a Generation UI fix for #106; the active competition only accepts Leaderboard UI, so the branch was rewritten to the approved Leaderboard surface.

Changes

  • Search field gains an inline clear (X) control when a query is present.
  • Active filter/search shows a Clear chip in the filter row and an aria-live match summary.
  • Empty state distinguishes "No Matching PRs" (filters active) from "No Resolved PRs", with a Clear filters action.
  • Touches only approved files: LeaderboardBoard.tsx, styles.css.

Testing

  • Manual testing
  • UI lint and build pass
  • CI passes

Visual Evidence

Leaderboard history filters with Clear controls and No Matching PRs empty state

Notes

Supersedes the Generation UI attempts on this PR and #121. Same payload previously opened as #123 (closed to satisfy the one-open-Leaderboard-PR rule).

Sidebar session clicks only updated the active id, so a draft typed in
one session could be sent into another after switching (gittensor-agent-forge#106).

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown

This PR was closed because the active competition accepts only scoped Leaderboard UI submissions.

  • PR title must use a conventional prefix, for example style: refine leaderboard filters.
  • The active competition accepts only Leaderboard UI submissions. Select Leaderboard UI in the PR template.

Update the PR title, description, and files, then reopen the PR.

@github-actions github-actions Bot closed this Jul 24, 2026
@marktech0813 marktech0813 changed the title fix(ui): clear composer draft when switching generation sessions style: refine leaderboard history filters with clear controls Jul 24, 2026
@github-actions

Copy link
Copy Markdown

This PR was closed because the active competition accepts only scoped Leaderboard UI submissions.

  • Leaderboard UI PRs may only touch the approved leaderboard UI surface; remove: "imagent-ui/app/components/GenerationChat.tsx"

Update the PR title, description, and files, then reopen the PR.

@marktech0813

Copy link
Copy Markdown
Author

Cannot reopen this PR after the branch was force-pushed with Leaderboard-only files (GitHub: “state cannot be changed. The branch was force-pushed or recreated.”).

Compliant replacement: #124 — same Leaderboard UI fix (clearable history filters), approved template + allowed files only. Generation UI (#106) remains out of scope for the active competition.

@marktech0813

Copy link
Copy Markdown
Author

Update: GitHub permanently refuses to reopen this PR (Could not open the pull request even after restoring the original tip SHA). The live Leaderboard UI submission is the open replacement PR linked below — same approved files/template.

@marktech0813

Copy link
Copy Markdown
Author

Live replacement: #125 (Leaderboard UI, same clearable-filters fix). #122 cannot be reopened by GitHub after the branch rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant