Add experiments using ConfigCat with PortsView #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustard-mh
force-pushed
the
hw/ports-exp
branch
from
9329b13 to
a1b51cf
Compare
jeanp413
reviewed
Sep 5, 2022
jeanp413
reviewed
Sep 5, 2022
Comment on lines
587
to
590
| const isEnabled = isSaaSGitpod | ||
| ? (await experiments.get<boolean>('gitpod.experimental.portsView.enabled', (await context.user).id))! | ||
| : vscode.workspace.getConfiguration('gitpod').get<boolean>('experimental.portsView.enabled')!; |
There was a problem hiding this comment.
Should this apply to all users or not @akosyakov ?
There was a problem hiding this comment.
I think generally there is no big concern, since SH installations should be updated to have this code. Hopefully we finish experiment by next SH release. But just to be on safe side let's have a guard. Imagine if SH team does a patch release and enables an experiment for SH users or something like that.
jeanp413
force-pushed
the
gp-code/main
branch
from
06783e7 to
f3fac9c
Compare
mustard-mh
force-pushed
the
hw/ports-exp
branch
from
a1b51cf to
97902a3
Compare
akosyakov
reviewed
Sep 6, 2022
akosyakov
reviewed
Sep 6, 2022
akosyakov
reviewed
Sep 6, 2022
mustard-mh
force-pushed
the
hw/ports-exp
branch
from
53c3e27 to
3628b6d
Compare
jeanp413
reviewed
Sep 6, 2022
mustard-mh
force-pushed
the
hw/ports-exp
branch
from
87ba610 to
3ccbb66
Compare
akosyakov
force-pushed
the
gp-code/main
branch
from
b0a9999 to
cf7bec5
Compare
mustard-mh
force-pushed
the
hw/ports-exp
branch
from
8f5ec56 to
5ea73bd
Compare
akosyakov
reviewed
Sep 7, 2022
jeanp413
force-pushed
the
gp-code/main
branch
from
cf7bec5 to
48bb437
Compare
akosyakov
force-pushed
the
gp-code/main
branch
from
1518919 to
e8e8a93
Compare
mustard-mh
force-pushed
the
hw/ports-exp
branch
2 times, most recently
from
1ac3a7c to
afeadc3
Compare
akosyakov
reviewed
Sep 9, 2022
akosyakov
reviewed
Sep 9, 2022
|
Post test result My team id as disable, using Remote Explorer
Team id enable(need to wait config.json cache refreshed, around 1 minute and refresh workspace), using PortsView
Copy button ports event
|
akosyakov
force-pushed
the
gp-code/main
branch
from
e2c3ab1 to
58baf65
Compare
|
@mustard-mh Could you rebase it please? 🙏 |
akosyakov
force-pushed
the
gp-code/main
branch
from
b133f64 to
1493922
Compare
mustard-mh
force-pushed
the
hw/ports-exp
branch
from
c184c5d to
9fe4352
Compare
|
Rebased to |
jeanp413
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve port event
<a>click as openBrowser eventAdd experiments using ConfigCat with experimental PortsView
gitpod_experimental_portsView_enabledexperiments.tsis a copy of experiments.tsHow to Test