More segment improvements #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
========================================
- Coverage 8.39% 8.37% -0.03%
========================================
Files 20 20
Lines 3394 3403 +9
========================================
Hits 285 285
- Misses 3057 3066 +9
Partials 52 52 |
aledbf
reviewed
Jul 4, 2023
cmd/exec.go
Outdated
| @@ -213,6 +213,7 @@ func executeCommandInLocations(execCmd []string, locs []commandExecLocation, par | |||
| go io.Copy(ptmx, os.Stdin) | |||
| if parallel { | |||
| wg.Add(1) | |||
| loc := loc | |||
There was a problem hiding this comment.
capture the variable because it's used in the go routine below
There was a problem hiding this comment.
Right, why not pass the variable to the goroutine as a parameter to make it explicit?
Like
go func(loc XXX) {
defer wg.Done()
err = cmd.Wait()
if err != nil {
log.Errorf("execution failed in %s (%s): %v", loc.Name, loc.Dir, err)
}
}(loc)
aledbf
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Report build start and finish. Let's us detect build runner failures.