Migrate more of the Dashboard to Podkit buttons #19012
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
filiptronicek
commented
Nov 4, 2023
| @@ -138,6 +138,10 @@ export class GitpodHostUrl { | |||
| return this.url.toString(); | |||
| } | |||
|
|
|||
| toRelative(): string { | |||
There was a problem hiding this comment.
This is needed because the <Link>s do not support full-blown URLs, just relative ones.
|
In the future, we also need to take a look into how we approach variant combinations: we use |
FromReferrer and PersonalAccessTokensCreateView
|
Succeeded by #19097 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some double-focus issues and continues on EXP-838. I am not sure about buttons with
.gp-linkand will need to look into transitioning them further.This brings our non-admin
<button>total from 76 to 65.Summary generated by Copilot
🤖 Generated by Copilot at 8eeeb20
This pull request updates several dashboard components to use the
LinkButtoncomponent from the@podkit/buttonspackage, which improves the code readability and the UI consistency. It also fixes a typo in a comment and adds a new method to theGitpodHostUrlclass.Related Issue(s)
Supersedes #18007
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold