fix(antares): use local fuse layer for metadata writes - #9
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e25e70622d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| futures = "0.3.31" | ||
| uuid = { version = "1.20.0", features = ["v4"] } | ||
| libfuse-fs = { version = "0.1.13"} | ||
| libfuse-fs = { path = "../rk8s/project/libfuse-fs" } |
There was a problem hiding this comment.
This path dependency resolves outside the repository (../rk8s/project/libfuse-fs), but the checkout only contains scorpiofs; a fresh checkout cannot build or run CI because cargo check --all-targets now fails with failed to read /workspace/rk8s/project/libfuse-fs/Cargo.toml. The rfuse3 path above has the same portability problem, so these local dependencies need to be vendored/workspaced in the repo or replaced with versioned/git dependencies before this can be merged.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fd4cbc86c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -18,6 +18,9 @@ jobs: | |||
| rust: [stable, beta] | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
There was a problem hiding this comment.
This workflow now satisfies the ../rk8s/... path dependencies by cloning a branch head, so the same scorpiofs commit can build different rfuse3/libfuse-fs code whenever codex/stabilize-libfuse-buck2-races is advanced, force-pushed, or deleted; I checked git clone -h, and --branch just checks out the named branch rather than an immutable revision. Since the lockfile cannot pin path dependencies, please checkout a fixed commit/tag (or make these real git/submodule dependencies) in this step and the matching workflow copies.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fd4cbc86c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -18,6 +18,9 @@ jobs: | |||
| rust: [stable, beta] | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
There was a problem hiding this comment.
This workflow now satisfies the ../rk8s/... path dependencies by cloning a branch head, so the same scorpiofs commit can build different rfuse3/libfuse-fs code whenever codex/stabilize-libfuse-buck2-races is advanced, force-pushed, or deleted; I checked git clone -h, and --branch just checks out the named branch rather than an immutable revision. Since the lockfile cannot pin path dependencies, please checkout a fixed commit/tag (or make these real git/submodule dependencies) in this step and the matching workflow copies.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4424423a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tokio = { version = "1.49.0", features = ["full"] } | ||
| axum = { version = "0.8.8", features = ["macros"] } | ||
| rfuse3 = { version = "0.0.8", features = ["tokio-runtime", "unprivileged", "file-lock"] } | ||
| rfuse3 = { git = "https://github.com/rk8s-dev/rk8s.git", branch = "codex/stabilize-libfuse-buck2-races", features = [ |
There was a problem hiding this comment.
This crate is published on crates.io, and Cargo rejects publishing packages that contain normal git dependencies unless they also specify a registry version fallback; the Cargo Book calls out that crates.io does not allow dependencies on code outside crates.io and recommends the git+version form for publishing. This applies to both rfuse3 here and libfuse-fs below, so the next release/package will fail unless the previous versions are kept alongside the git override or the dependencies are moved back to published crates.
Useful? React with 👍 / 👎.
2 participants
Summary
Validation