Moves the mcp registration completed event to global telemetry

Author: d13

docs/telemetry-events.md

@@ -33,6 +33,7 @@
   'global.enabled': boolean,
   'global.folders.count': number,
   'global.folders.schemes': string,
+  'global.gk.mcp.registrationCompleted': boolean,
   'global.install': boolean,
   'global.prerelease': boolean,
   'global.providers.count': number,
@@ -2764,18 +2765,6 @@ void
 }
 ```
 
-### mcp/registration/completed
-
-> Sent when GitKraken MCP registration is completed
-
-```typescript
-{
-  'cli.version': string,
-  'requiresUserCompletion': boolean,
-  'source': 'account' | 'subscription' | 'graph' | 'composer' | 'patchDetails' | 'settings' | 'timeline' | 'home' | 'ai' | 'ai:markdown-preview' | 'ai:markdown-editor' | 'ai:picker' | 'associateIssueWithBranch' | 'cloud-patches' | 'code-suggest' | 'commandPalette' | 'deeplink' | 'editor:hover' | 'feature-badge' | 'feature-gate' | 'gk-cli-integration' | 'gk-mcp-provider' | 'inspect' | 'inspect-overview' | 'integrations' | 'launchpad' | 'launchpad-indicator' | 'launchpad-view' | 'mcp' | 'mcp-welcome-message' | 'merge-target' | 'notification' | 'prompt' | 'quick-wizard' | 'rebaseEditor' | 'remoteProvider' | 'scm' | 'scm-input' | 'startWork' | 'trial-indicator' | 'view' | 'walkthrough' | 'whatsnew' | 'worktrees'
-}
-```
-
 ### mcp/registration/failed
 
 > Sent when GitKraken MCP registration fails

src/constants.telemetry.ts

@@ -36,6 +36,7 @@ export interface TelemetryGlobalContext extends SubscriptionEventData {
 	upgradedFrom: string | undefined;
 	'folders.count': number;
 	'folders.schemes': string;
+	'gk.mcp.registrationCompleted': boolean;
 	'providers.count': number;
 	'providers.ids': string;
 	'repositories.count': number;
@@ -251,8 +252,6 @@ export interface TelemetryEvents extends WebviewShowAbortedEvents, WebviewShownE
 	'mcp/setup/completed': MCPSetupCompletedEvent;
 	/** Sent when GitKraken MCP setup fails */
 	'mcp/setup/failed': MCPSetupFailedEvent;
-	/** Sent when GitKraken MCP registration is completed */
-	'mcp/registration/completed': MCPSetupCompletedEvent;
 	/** Sent when GitKraken MCP registration fails */
 	'mcp/registration/failed': MCPSetupFailedEvent;
 

src/env/node/gk/mcp/integration.ts

@@ -71,7 +71,7 @@ export class GkMcpProvider implements McpServerDefinitionProvider, Disposable {
 		try {
 			const configuration = JSON.parse(output) as { name: string; type: string; command: string; args: string[] };
 
-			this.notifySetupCompleted(cliInstall.version);
+			this.notifyRegistrationCompleted(cliInstall.version);
 
 			return {
 				name: configuration.name,
@@ -82,23 +82,19 @@ export class GkMcpProvider implements McpServerDefinitionProvider, Disposable {
 			};
 		} catch (ex) {
 			Logger.error(`Error getting MCP configuration: ${ex}`);
-			this.notifySetupFailed('Error getting MCP configuration', undefined, cliInstall.version);
+			this.notifyRegistrationFailed('Error getting MCP configuration', undefined, cliInstall.version);
 		}
 
 		return undefined;
 	}
 
-	private notifySetupCompleted(cliVersion?: string | undefined) {
+	private notifyRegistrationCompleted(_cliVersion?: string | undefined) {
 		if (!this.container.telemetry.enabled) return;
 
-		this.container.telemetry.sendEvent('mcp/registration/completed', {
-			requiresUserCompletion: false,
-			source: 'gk-mcp-provider',
-			'cli.version': cliVersion,
-		});
+		this.container.telemetry.setGlobalAttribute('gk.mcp.registrationCompleted', true);
 	}
 
-	private notifySetupFailed(reason: string, message?: string | undefined, cliVersion?: string | undefined) {
+	private notifyRegistrationFailed(reason: string, message?: string | undefined, cliVersion?: string | undefined) {
 		if (!this.container.telemetry.enabled) return;
 
 		this.container.telemetry.sendEvent('mcp/registration/failed', {