Skip to content

Commit b34622b

Browse files
committed
Updates telemetry to split mcp server registration from mcp setup
1 parent bf84c13 commit b34622b

File tree

3 files changed

+31
-2
lines changed

3 files changed

+31
-2
lines changed

docs/telemetry-events.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2764,6 +2764,31 @@ void
27642764
}
27652765
```
27662766

2767+
### mcp/registration/completed
2768+
2769+
> Sent when GitKraken MCP registration is completed
2770+
2771+
```typescript
2772+
{
2773+
'cli.version': string,
2774+
'requiresUserCompletion': boolean,
2775+
'source': 'account' | 'subscription' | 'graph' | 'composer' | 'patchDetails' | 'settings' | 'timeline' | 'home' | 'ai' | 'ai:markdown-preview' | 'ai:markdown-editor' | 'ai:picker' | 'associateIssueWithBranch' | 'cloud-patches' | 'code-suggest' | 'commandPalette' | 'deeplink' | 'editor:hover' | 'feature-badge' | 'feature-gate' | 'gk-cli-integration' | 'gk-mcp-provider' | 'inspect' | 'inspect-overview' | 'integrations' | 'launchpad' | 'launchpad-indicator' | 'launchpad-view' | 'mcp' | 'mcp-welcome-message' | 'merge-target' | 'notification' | 'prompt' | 'quick-wizard' | 'rebaseEditor' | 'remoteProvider' | 'scm' | 'scm-input' | 'startWork' | 'trial-indicator' | 'view' | 'walkthrough' | 'whatsnew' | 'worktrees'
2776+
}
2777+
```
2778+
2779+
### mcp/registration/failed
2780+
2781+
> Sent when GitKraken MCP registration fails
2782+
2783+
```typescript
2784+
{
2785+
'cli.version': string,
2786+
'error.message': string,
2787+
'reason': string,
2788+
'source': 'account' | 'subscription' | 'graph' | 'composer' | 'patchDetails' | 'settings' | 'timeline' | 'home' | 'ai' | 'ai:markdown-preview' | 'ai:markdown-editor' | 'ai:picker' | 'associateIssueWithBranch' | 'cloud-patches' | 'code-suggest' | 'commandPalette' | 'deeplink' | 'editor:hover' | 'feature-badge' | 'feature-gate' | 'gk-cli-integration' | 'gk-mcp-provider' | 'inspect' | 'inspect-overview' | 'integrations' | 'launchpad' | 'launchpad-indicator' | 'launchpad-view' | 'mcp' | 'mcp-welcome-message' | 'merge-target' | 'notification' | 'prompt' | 'quick-wizard' | 'rebaseEditor' | 'remoteProvider' | 'scm' | 'scm-input' | 'startWork' | 'trial-indicator' | 'view' | 'walkthrough' | 'whatsnew' | 'worktrees'
2789+
}
2790+
```
2791+
27672792
### mcp/setup/completed
27682793

27692794
> Sent when GitKraken MCP setup is completed

src/constants.telemetry.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,10 @@ export interface TelemetryEvents extends WebviewShowAbortedEvents, WebviewShownE
251251
'mcp/setup/completed': MCPSetupCompletedEvent;
252252
/** Sent when GitKraken MCP setup fails */
253253
'mcp/setup/failed': MCPSetupFailedEvent;
254+
/** Sent when GitKraken MCP registration is completed */
255+
'mcp/registration/completed': MCPSetupCompletedEvent;
256+
/** Sent when GitKraken MCP registration fails */
257+
'mcp/registration/failed': MCPSetupFailedEvent;
254258

255259
/** Sent when a PR review was started in the inspect overview */
256260
openReviewMode: OpenReviewModeEvent;

src/env/node/gk/mcp/integration.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export class GkMcpProvider implements McpServerDefinitionProvider, Disposable {
9191
private notifySetupCompleted(cliVersion?: string | undefined) {
9292
if (!this.container.telemetry.enabled) return;
9393

94-
this.container.telemetry.sendEvent('mcp/setup/completed', {
94+
this.container.telemetry.sendEvent('mcp/registration/completed', {
9595
requiresUserCompletion: false,
9696
source: 'gk-mcp-provider',
9797
'cli.version': cliVersion,
@@ -101,7 +101,7 @@ export class GkMcpProvider implements McpServerDefinitionProvider, Disposable {
101101
private notifySetupFailed(reason: string, message?: string | undefined, cliVersion?: string | undefined) {
102102
if (!this.container.telemetry.enabled) return;
103103

104-
this.container.telemetry.sendEvent('mcp/setup/failed', {
104+
this.container.telemetry.sendEvent('mcp/registration/failed', {
105105
reason: reason,
106106
'error.message': message,
107107
source: 'gk-mcp-provider',

0 commit comments

Comments
 (0)