Restore benchmarks results page#257
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/githubnext/tsessebe/sessions/7d19c40b-04fe-4225-94ab-afaf8ba1fa7b Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Revert changes to restore benchmarks page
Restore benchmarks results page
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
playground/benchmarks.htmlwas unintentionally converted into a generic interactive playground by commitd0b6262("Standardize all playground pages and add conformance tests"), losing the tsb-vs-pandas results table that aggregates every benchmark.Changes
playground/benchmarks.html— Restored to the pre-d0b6262version: the "Detailed Results" table (function, tsb ms, pandas ms, ratio, faster) populated frombenchmarks/results.json, plus the Methodology and About panels.tests/playground.test.ts— Addedbenchmarks.htmltoNON_PLAYGROUND_PAGESso the playground-conformance suite skips it, alongside the existingindex.htmlexemption. This is what previously pressured the page into the playground shape.Not changed
The earlier removal of the "Visual Comparison" bar chart (commit
1172c14) is left as-is — the issue refers to "the chart … where we listed every single benchmark", which is the results table restored here. Happy to also revert1172c14if the bar chart was in fact what was meant.