Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 6, 2026

Updates firewall logging terminology from "denied" to "blocked" for consistency with standard security conventions.

Changes

Go code

  • Struct fields: DeniedDomainsBlockedDomains, DeniedRequestsBlockedRequests, DeniedCountBlockedCount
  • JSON tags: denied_domainsblocked_domains, denied_requestsblocked_requests
  • Interfaces: GetDeniedDomains()GetBlockedDomains(), SetDeniedDomains()SetBlockedDomains()
  • DomainRequestStats: Denied field → Blocked

JavaScript

  • Variables: deniedRequests, deniedDomains, stats.denied
  • Table headers: | Domain | Allowed | Denied || Domain | Allowed | Blocked |

Documentation

  • Console output: "Denied Domains:" → "Blocked Domains:"
  • Section headers: "Troubleshooting Firewall Denials" → "Troubleshooting Firewall Blocking"
  • Help text and API descriptions

Example

Before:

{
  "firewall_log": {
    "denied_requests": 3,
    "denied_domains": ["blocked.example.com:443"],
    "requests_by_domain": {
      "blocked.example.com:443": {"allowed": 0, "denied": 2}
    }
  }
}

After:

{
  "firewall_log": {
    "blocked_requests": 3,
    "blocked_domains": ["blocked.example.com:443"],
    "requests_by_domain": {
      "blocked.example.com:443": {"allowed": 0, "blocked": 2}
    }
  }
}
Original prompt

Review all uses of the "denied" term, in the context of denied domains of the firewall, and update to "blocked"


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.


Changeset

  • Type: minor
  • Description: Rename firewall terminology from "denied" to "blocked" in Go structs, JSON fields, interfaces, JavaScript variables, table headers, and documentation. This is a breaking change: integrations must update to use blocked_* fields and blocked in per-domain stats.

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator

Copilot AI changed the title [WIP] Update 'denied' term to 'blocked' for firewall domains Replace "denied" with "blocked" for firewall domain terminology Jan 6, 2026
Copilot AI requested a review from pelikhan January 6, 2026 14:59
@pelikhan pelikhan added the smoke label Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

📰 VERDICT: Smoke Copilot Playwright has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Smoke Test Results

✅ File Writing: Created test file successfully
✅ Bash Tool: File read verification successful
❌ Safe Input gh Tool: Not available in this workflow context

Status: PARTIAL PASS (2/3 tests passed)

Note: safeinputs-gh tool not available - GitHub MCP disabled and safe-inputs gh tool not configured in this workflow.

AI generated by Smoke Copilot Safe Inputs

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Smoke Test Results - Copilot Engine (Run #20752502006)

Last 2 Merged PRs: #9129, #9128

✅ GitHub MCP Testing - Retrieved PR data successfully
✅ File Writing Testing - Created /tmp/gh-aw/agent/smoke-test-copilot-20752502006.txt
✅ Bash Tool Testing - Verified file with cat command
✅ GitHub MCP Default Toolset Testing - get_me unavailable with default toolsets (403 permission error as expected)
✅ Cache Memory Testing - Created and verified /tmp/gh-aw/cache-memory/smoke-test-20752502006.txt
✅ Web Fetch Testing - Successfully fetched GitHub API data
✅ Available Tools - github-, safeoutputs-, bash, web_fetch, view, grep, glob, edit, create, task, skill

Overall Status: ✅ PASS

cc: @pelikhan

AI generated by Smoke Copilot

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

✅ Smoke test passed for Copilot engine (no firewall)
✅ Retrieved 2 merged PRs (#9129, #9128)
✅ Created test file successfully
✅ Navigated to github.com with Playwright
✅ Listed 3 issues via safeinputs-gh tool

AI generated by Smoke Copilot No Firewall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

PRs: Add missing list-tools subcommand to MCP help text | Document allowed-github-references field for controlling timeline items in SideRepoOps
OpenAI curl blocked: ✅ (DNS fail)
GitHub MCP (last 2 merged PR titles fetched): ✅
File write/read /tmp/gh-aw/agent/smoke-test-codex-firewall-20752502022.txt: ✅
Blocked domain curl (example.com): ✅ (DNS fail)
Network status: SANDBOXED
Overall: PASS

AI generated by Smoke Codex Firewall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Smoke Test Results - Run 20752502017

  • ❌ Playwright MCP: Tool not available
  • ✅ Cache Memory: Successfully wrote and verified test file
  • ❌ Safe Input gh: Tool not available

Overall Status: FAIL

Note: playwright and safeinputs-gh tools are not available in this workflow execution environment.

AI generated by Smoke Copilot Playwright

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

PRs checked: 9129 Add missing list-tools subcommand to MCP help text; 9128 Document allowed-github-references field for controlling timeline items in SideRepoOps
GitHub MCP: ✅
File write/read (/tmp/gh-aw/agent): ✅
Cache memory write/read (/tmp/gh-aw/cache-memory): ✅
Playwright title check (github.com): ✅
safeinputs-gh (gh issues list): ❌ tool unavailable
Overall: FAIL

AI generated by Smoke Codex

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Smoke Test Results (Run 20752502016)

Last 2 Merged PRs:

Test Results:

  • ✅ GitHub MCP: Retrieved recent PRs
  • ✅ File Write: Created /tmp/gh-aw/agent/smoke-test-claude-20752502016.txt
  • ✅ Bash Tool: Verified file creation
  • ✅ Playwright MCP: Loaded GitHub homepage (title confirmed)
  • ✅ Cache Memory: Created /tmp/gh-aw/cache-memory/smoke-test-20752502016.txt
  • ❌ Safe Input gh Tool: Not available/not tested

Overall Status: PASS (5/6 tests passed; gh tool unavailable per system config)

AI generated by Smoke Claude

@pelikhan pelikhan marked this pull request as ready for review January 6, 2026 15:55
@pelikhan pelikhan merged commit 6384d58 into main Jan 6, 2026
91 checks passed
@pelikhan pelikhan deleted the copilot/update-denied-term-to-blocked branch January 6, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants