-
Notifications
You must be signed in to change notification settings - Fork 34
Replace "denied" with "blocked" for firewall domain terminology #9118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: pelikhan <[email protected]>
…text Co-authored-by: pelikhan <[email protected]>
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: pelikhan <[email protected]>
|
✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️ |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 VERDICT: Smoke Copilot Playwright has concluded. All systems operational. This is a developing story. 🎤 |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS. |
Smoke Test Results✅ File Writing: Created test file successfully Status: PARTIAL PASS (2/3 tests passed) Note:
|
Smoke Test Results - Copilot Engine (Run #20752502006)Last 2 Merged PRs: #9129, #9128 ✅ GitHub MCP Testing - Retrieved PR data successfully Overall Status: ✅ PASS cc: @pelikhan
|
|
✅ Smoke test passed for Copilot engine (no firewall)
|
|
PRs: Add missing list-tools subcommand to MCP help text | Document allowed-github-references field for controlling timeline items in SideRepoOps
|
Smoke Test Results - Run 20752502017
Overall Status: FAIL Note:
|
|
PRs checked: 9129 Add missing list-tools subcommand to MCP help text; 9128 Document allowed-github-references field for controlling timeline items in SideRepoOps
|
Smoke Test Results (Run 20752502016)Last 2 Merged PRs:
Test Results:
Overall Status: PASS (5/6 tests passed; gh tool unavailable per system config)
|
Updates firewall logging terminology from "denied" to "blocked" for consistency with standard security conventions.
Changes
Go code
DeniedDomains→BlockedDomains,DeniedRequests→BlockedRequests,DeniedCount→BlockedCountdenied_domains→blocked_domains,denied_requests→blocked_requestsGetDeniedDomains()→GetBlockedDomains(),SetDeniedDomains()→SetBlockedDomains()Deniedfield →BlockedJavaScript
deniedRequests,deniedDomains,stats.denied| Domain | Allowed | Denied |→| Domain | Allowed | Blocked |Documentation
Example
Before:
{ "firewall_log": { "denied_requests": 3, "denied_domains": ["blocked.example.com:443"], "requests_by_domain": { "blocked.example.com:443": {"allowed": 0, "denied": 2} } } }After:
{ "firewall_log": { "blocked_requests": 3, "blocked_domains": ["blocked.example.com:443"], "requests_by_domain": { "blocked.example.com:443": {"allowed": 0, "blocked": 2} } } }Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Changeset
blocked_*fields andblockedin per-domain stats.