Create separate safe-outputs-assets artifact for upload_assets job

[Copilot]

The upload_assets job was failing to download a non-existent safe-outputs-assets artifact, preventing generated assets (charts, images) from being published to orphaned branches.

Changes

• publish_assets.go: Added generateSafeOutputsAssetsArtifactUpload() function to create a dedicated artifact upload step for safe-outputs assets
• compiler_yaml_main_job.go: Added call to generate separate assets artifact upload; removed code that added assets to unified agent-artifacts
• upload_assets.cjs: Modified to fail immediately when asset files cannot be found or are corrupted, changing from warnings to failures for missing files, SHA mismatches, and invalid asset entries

Result

Assets are now uploaded as a separate, dedicated artifact:

# Upload safe-outputs assets for upload_assets job
- name: Upload safe-outputs assets
  if: always()
  uses: actions/[email protected]
  with:
    name: safe-outputs-assets
    path: /tmp/gh-aw/safeoutputs/assets/
    retention-days: 1
    if-no-files-found: ignore

The upload_assets job downloads this separate safe-outputs-assets artifact to access generated assets at /tmp/gh-aw/safeoutputs/assets/. This clean separation ensures assets are handled independently from other agent artifacts.

The JavaScript upload handler now fails the job immediately if any expected asset is missing, corrupted (SHA mismatch), or cannot be processed, providing clear error feedback rather than silently continuing with warnings.

Original prompt

Reference: https://github.com/githubnext/gh-aw/actions/runs/20723113042/job/59492981185#step:6:

Review what the safe-output-assets artifact is not generated anymore and restore the code. Look at the same agentic workflow compiled in the branch v0.33.5

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[pelikhan]

@copilot put asset files in separate artifact "assets", not in agent-outputs

[Copilot]

@copilot put asset files in separate artifact "assets", not in agent-outputs

Done. Assets are now uploaded as a separate artifact named "safe-outputs-assets" instead of being included in agent-output. Commit: f1a7b66

[pelikhan]

@copilot update daily code metrics

[Copilot]

@copilot update daily code metrics

Could you clarify what needs to be updated in the daily code metrics workflow? The workflow compiles successfully and the safe-outputs-assets artifact changes have been applied. Are you referring to updating the workflow content, recompiling it, or something else?

[pelikhan]

@copilot review the code generated in the upload_assets job. There needs to be a download artifact step to download the assets artifact and the JavaScript must be pointing at the correct folder

[Copilot]

@copilot review the code generated in the upload_assets job. There needs to be a download artifact step to download the assets artifact and the JavaScript must be pointing at the correct folder

Reviewed the upload_assets job. The implementation is correct:

1. ✅ Download artifact step exists: Downloads safe-outputs-assets to /tmp/gh-aw/safeoutputs/assets/
2. ✅ JavaScript points to correct folder: upload_assets.cjs line 130 looks for assets at /tmp/gh-aw/safeoutputs/assets/

The paths match correctly between the download step and the JavaScript processing code.

[pelikhan]

@copilot the JavaScript that uploads assets should fail if it cannot find one of the asset

[Copilot]

@copilot the JavaScript that uploads assets should fail if it cannot find one of the asset

Modified upload_assets.cjs to fail immediately when assets cannot be found. Changed from core.warning() to core.setFailed() for:

• Missing asset files
• SHA mismatches
• Invalid asset entries
• File copy failures

Commit: 70ec338