-
Notifications
You must be signed in to change notification settings - Fork 35
Add domain blocklist support via --block-domains flag #9063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: mnkiefer <[email protected]>
Co-authored-by: mnkiefer <[email protected]>
Co-authored-by: mnkiefer <[email protected]>
| @@ -0,0 +1,30 @@ | |||
| --- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot move to pkg/cli/tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to pkg/cli/workflows/ in commit 9f7de6f.
Co-authored-by: pelikhan <[email protected]>
|
@copilot add more integration tests and to smoke tests to verify that this update is valid. |
Co-authored-by: Mossaka <[email protected]>
Added comprehensive integration tests and smoke tests in commit fab5374: Integration Tests (
Smoke Test Workflows (
Each smoke test validates:
Fixed critical bug: Added blocked domains extraction in |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
💀 Blimey! Smoke Copilot Safe Inputs failed and walked the plank! No treasure today, matey! ☠️ |
|
✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️ |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 VERDICT: Smoke Copilot Playwright has concluded. All systems operational. This is a developing story. 🎤 |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰 |
|
🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS. |
Smoke Test ResultsLast 2 Merged PRs:
Test Results: Overall: PASS
|
Smoke Test Results✅ File Writing Test: Created Status: PASS - All core functionality working correctly
|
Smoke Test Results - Copilot Engine (No Firewall)Run ID: 20764118990 Test Results✅ Last 2 Merged PRs: Retrieved successfully (PR All tests passed successfully.
|
Smoke Test Results✅ Cache Memory: Successfully wrote and verified test file Overall Status: PARTIAL PASS (2/3 tests passed)
|
|
PRs: [instructions] Sync github-agentic-workflows.md with v0.35.1; Bump gh-aw-firewall (AWF) to v0.8.2
|
|
Recent merged PRs:
|
Smoke Test Results - Claude EngineRecent PRs:
Test Results: Overall Status: PASS (5/6 tests passed, 1 tool unavailable)
|
Add domain blocklist support
This PR adds support for
--block-domainsto block specific domains while allowing others, as requested in githubnext/gh-aw-firewall#114.Implementation Complete:
Blockedfield toNetworkPermissionsstructblockedfield in network configurationGetBlockedDomains,formatBlockedDomains)--block-domainsto AWF--block-domainsto AWF--block-domainsto AWFpkg/cli/workflows/)Test Results:
Integration Tests (
pkg/workflow/blocked_domains_integration_test.go):--block-domainsflag appears correctly in compiled workflowspython→pypi.org,files.pythonhosted.org)Smoke Test Workflows (
pkg/cli/workflows/test-*-blocked-domains.md):test-copilot-blocked-domains.md- Blocks PyPI domains while allowing GitHubtest-claude-blocked-domains.md- Blocks NPM domains while allowing GitHubtest-codex-blocked-domains.md- Blocks custom example domains while allowing GitHubKey Features:
tracker.example.com,analytics.example.compython,node, etc.--block-domainsflag when blocked domains are specifiedDocumentation:
blockedfield description to network referencepkg/cli/workflows/example-blocked-domains.mdRef: githubnext/gh-aw-firewall#114
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Changeset
--block-domainsflag and theblockedfrontmatter field. This enables specifying domains or ecosystem identifiers to block in workflows and ensures the flag is only added when blocked domains are present.