Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 5, 2026

The add_labels.test.cjs file was using Node.js native test runner instead of vitest, causing test suite discovery failures. Additionally, the empty labels test expected error behavior when the code actually handles it gracefully as success.

Changes

  • Test framework migration - Converted from node:test to vitest

    • Changed imports: require("node:test")import { describe, it, expect, beforeEach } from "vitest"
    • Replaced all assertions: assert.strictEqual()expect().toBe(), assert.deepStrictEqual()expect().toEqual()
  • Empty labels test fix - Updated expectation to match actual code behavior

    // Before: expected failure
    expect(result.success).toBe(false);
    
    // After: expects graceful success (no-op)
    expect(result.success).toBe(true);
    expect(result.labelsAdded).toEqual([]);
    expect(result.message).toBe("No valid labels found");
  • Code formatting - Applied Prettier to add_labels.cjs (single-line ternary expressions)

All 15 tests now pass with proper vitest integration.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Clean add_labels.cjs for conciseness and maintainability Fix add_labels.test.cjs test framework and empty labels behavior Jan 5, 2026
Copilot AI requested a review from pelikhan January 5, 2026 15:25
@pelikhan pelikhan marked this pull request as ready for review January 5, 2026 16:02
@pelikhan pelikhan merged commit baa6970 into jsweep-clean-add-labels-1c0bc3cff1aee696 Jan 5, 2026
@pelikhan pelikhan deleted the copilot/sub-pr-9005 branch January 5, 2026 16:02
pelikhan added a commit that referenced this pull request Jan 5, 2026
* jsweep: Clean add_labels.cjs

- Simplified item number determination with ternary expression
- Consolidated error handling for invalid/missing item numbers
- Removed unnecessary intermediate variables
- Used spread operator for context.repo
- Used shorthand property for contextType
- Created comprehensive test file with 13 test cases
- Reduced from 146 to 133 lines (13 lines saved)

* Fix add_labels.test.cjs test framework and empty labels behavior (#9006)

* Initial plan

* Fix add_labels.test.cjs to use vitest and fix empty labels test expectation

Co-authored-by: pelikhan <[email protected]>

* Apply prettier formatting to add_labels.cjs (single-line ternary expressions)

Co-authored-by: pelikhan <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: pelikhan <[email protected]>

* Add changeset [skip-ci]

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: Peli de Halleux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants