Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 4, 2026

The included_file_schema.json was missing neutral tool definitions (edit, web-fetch, web-search, safety-prompt, timeout, startup-timeout), causing validation errors when these tools were imported from shared workflows.

Changes

  • Schema sync: Added 6 missing neutral tool definitions to included_file_schema.json to match main_workflow_schema.json
  • Test updates:
    • Removed obsolete web-fetch MCP configuration checks (Copilot has native support)
    • Updated safe outputs test to expect consolidated process_safe_outputs step instead of individual steps
    • Added context.Context parameter to all RunWorkflow* test calls matching updated function signatures
  • Binary rebuild: Embedded updated schemas via //go:embed

Example

Previously, importing neutral tools in shared workflows failed validation:

# shared-tools.md
---
description: "Shared tool configuration"
tools:
  web-fetch:  # ❌ Validation error: got null, want string or object
  edit:       # ❌ Validation error: got null, want string or object
---

Now validates correctly:

# shared-tools.md
---
description: "Shared tool configuration"
tools:
  web-fetch:  # ✅ Validates as null (default configuration)
  edit:       # ✅ Validates as null (default configuration)
---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

- Added edit, web-fetch, web-search, safety-prompt, timeout, and startup-timeout tools to included_file_schema.json to match main_workflow_schema.json
- Fixed TestImportWebFetchTool and TestImportMultipleNeutralTools to reflect that Copilot has built-in web-fetch support (no explicit MCP configuration needed)
- Fixed TestConsolidatedSafeOutputsJobIntegration test expectations to use consolidated "process_safe_outputs" step
- Updated run_command_test.go to add context.Context parameter to all RunWorkflowOnGitHub and RunWorkflowsOnGitHub function calls
- Rebuilt binary to embed updated schemas

Co-authored-by: mnkiefer <[email protected]>
@mnkiefer mnkiefer marked this pull request as ready for review January 4, 2026 10:07
Copy link
Contributor Author

Copilot AI commented Jan 4, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login -json GO111MODULE ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE fydC0ElSIUKG env -json GO111MODULE 0.1-go1.25.0.lin-nilfunc GOINSECURE GOMOD GOMODCACHE 0.1-go1.25.0.lin-trimpath (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login ithub-script/git/ref/tags/v8 gh 6/x64/bin/node /ref/tags/v8 --jq (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login xterm-color gh ache/node/20.19.6/x64/bin/node 4340-93211/test-/home/REDACTED/go/pkg/mod/golang.org/[email protected]/pkg/too-importcfg --jq /usr/bin/gh infocmp -1 /ref/tags/v8 gh ux-amd64/pkg/tool/linux_amd64/vet /repos/actions/g../../scripts/build-release.sh --jq /home/REDACTED/go/pkg/mod/golang.org/[email protected] ux-amd64/pkg/tool/linux_amd64/vet (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Improve campaign orchestrator and project update contract fix: add missing neutral tools to included file schema and update test expectations Jan 4, 2026
Copilot AI requested a review from mnkiefer January 4, 2026 10:09
@mnkiefer mnkiefer merged commit 623c4eb into refactor-campaign-prompts Jan 4, 2026
122 of 124 checks passed
@mnkiefer mnkiefer deleted the copilot/sub-pr-8857 branch January 4, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants