Add allowed-repos field to safe output types for cross-repository operations #8837

Copilot · 2026-01-04T04:16:32Z

✅ Complete: Add allowed-repos field to safe output types

Summary

Successfully implemented the allowed-repos field for all safe output types that support cross-repository operations. The implementation adds a repo argument to safe output messages, which specifies the target repository. This argument must be either the configured target-repo or in the allowed-repos list.

The repo parameter is conditionally added to MCP tool definitions only when allowed-repos has entries, keeping tool schemas clean when cross-repository operations aren't configured.

Implementation Complete

Go Changes (100% Complete):

✅ Added AllowedRepos []string to SafeOutputTargetConfig (covers 10+ safe output types)
✅ Added AllowedRepos []string to standalone config types (AddCommentsConfig, CreatePullRequestsConfig, CreatePullRequestReviewCommentsConfig, CreateAgentTaskConfig)
✅ Updated compiler to pass allowed_repos in handler manager JSON config for all types
✅ Added target-repo to handler configs where missing
✅ Conditional tool schema generation: Added addRepoParameterIfNeeded() function that only adds repo parameter to MCP tool inputSchema when allowed-repos has entries
✅ Code formatted with make fmt
✅ Code linted - 0 issues

JavaScript Changes (100% Complete):

✅ add_comment.cjs - Added repo validation and cross-repo support
✅ create_pr_review_comment.cjs - Added repo validation and cross-repo support
✅ create_pull_request.cjs - Added repo validation and cross-repo support
✅ create_issue.cjs - Already had repo support
✅ create_discussion.cjs - Already had repo support
✅ Refactored: Created resolveAndValidateRepo() helper function to eliminate ~60 lines of duplicated code across handlers
✅ NEW: Created resolveTargetRepoConfig() helper that simplifies config initialization by combining parseAllowedRepos() and getDefaultTargetRepo() into a single call
✅ Code formatted with make lint-cjs - All files use Prettier code style

JSON Schema Updates (100% Complete):

✅ Updated both schema files with allowed-repos field for all applicable safe output types:
- pkg/parser/schemas/main_workflow_schema.json (embedded in Go binary)
- .github/aw/main_workflow_schema.json (published/imported schema)
✅ Added allowed-repos to 6 safe output types:
- create-issue (already existed)
- create-discussion (already existed)
- add-comment (newly added)
- create-pull-request (newly added)
- create-pull-request-review-comment (newly added)
- create-agent-task (newly added)
✅ All schemas include consistent description explaining the field's purpose and behavior
✅ Schemas validated and binary rebuilt with embedded schemas

Tests (100% Complete):

✅ repo_helpers.test.cjs - 29 comprehensive tests covering:
- parseAllowedRepos (7 tests) - arrays, strings, trimming, empty filtering
- getDefaultTargetRepo (4 tests) - config parameter, env var, context fallback, precedence
- validateRepo (4 tests) - default repo, allowed repos, rejection, error messages
- parseRepoSlug (5 tests) - valid slug, invalid formats, empty parts
- resolveAndValidateRepo (5 tests) - combined validation logic, success/failure scenarios
- resolveTargetRepoConfig (4 tests) - config initialization helper, various scenarios
✅ TestRepoParameterAddedOnlyWithAllowedRepos - 5 tests verifying conditional repo parameter behavior
✅ All tests passing (34/34 tests for repo functionality + parser tests)

MCP Tool Schema Enhancement

The MCP tool definitions now conditionally include the repo parameter based on configuration:

With allowed-repos configured:

safe-outputs:
  create-issue:
    allowed-repos:
      - org/other-repo

Generates tool with repo parameter:

{
  "name": "create_issue",
  "inputSchema": {
    "properties": {
      "title": { "type": "string" },
      "body": { "type": "string" },
      "repo": {
        "type": "string",
        "description": "Target repository in 'owner/repo' format. Must be the target-repo or in the allowed-repos list."
      }
    }
  }
}

Without allowed-repos: The repo parameter is omitted, keeping the tool definition minimal.

Code Quality Improvements

Repository Helper Functions:

resolveTargetRepoConfig(config) - Simplifies handler initialization:
- Combines parseAllowedRepos() and getDefaultTargetRepo() into a single call
- Returns {defaultTargetRepo, allowedRepos} for immediate use
- Eliminates ~30 lines of duplicated initialization code across handlers
resolveAndValidateRepo(item, defaultTargetRepo, allowedRepos, operationType) - Per-message validation:
- Resolves repository from item.repo field or default
- Validates against allowed-repos list
- Parses repository slug into owner/repo parts
- Returns structured result with comprehensive error handling

Benefits:

Eliminated ~90 lines of duplicated code across handlers
Consistent initialization pattern: const { defaultTargetRepo, allowedRepos } = resolveTargetRepoConfig(config);
Improved maintainability and readability
Clear separation: config parsing vs. per-message validation

Safe Output Types with allowed-repos Support

Types with individual AllowedRepos field (all have Go + JS + Schema support):

✅ create-issue
✅ create-discussion
✅ add-comments
✅ create-pull-requests
✅ create-pull-request-review-comments
✅ create-agent-task

Types using SafeOutputTargetConfig (automatic):

✅ add-labels, add-reviewer, assign-milestone, assign-to-agent, assign-to-user, close-issue, close-discussion, close-pull-request, hide-comment, link-sub-issue, mark-pull-request-as-ready-for-review, update-issue, update-discussion, update-pull-request

Quality Checks Completed

✅ Go code formatted and linted (0 issues)
✅ JavaScript formatted and linted (0 issues)
✅ JSON schemas validated (all valid in both files)
✅ Code review completed (no comments)
✅ All tests passing (34/34 tests for repo functionality + parser tests)
✅ Binary rebuilt with embedded schemas
✅ No breaking changes to existing functionality
✅ Code duplication eliminated through refactoring

Original prompt

Add the field "allowed-repos: string[]" to safe output types that specifies a list of additional repositories that can be targetted by the safe output (additionally to the target-repo).

the tool has an additional "repo" argument which contains the org/repo slug

the "repo" argument must be the target or in the allowed-repos

create and reuse helpers to resolve these as much as possible and reuse them in the safe outputs javascript
The mutation will be done for that resolved repo.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: pelikhan <[email protected]>

…idation Co-authored-by: pelikhan <[email protected]>

…wed-repos validation Co-authored-by: pelikhan <[email protected]>

…epos validation Co-authored-by: pelikhan <[email protected]>

pelikhan · 2026-01-04T04:48:28Z

@copilot format, lint go, lint js, review changes, add tests for helpers

pelikhan · 2026-01-04T04:49:25Z

@copilot only generate the "repo" tool argument if the allowed-repos configuration has entries. Otherwise, it is not needed when defining the tool in the safe output mcp server.

Co-authored-by: pelikhan <[email protected]>

Copilot · 2026-01-04T04:56:33Z

@copilot format, lint go, lint js, review changes, add tests for helpers

Completed all requested tasks:

✅ Format: Go code formatted with make fmt, JavaScript validated with make lint-cjs (all files use Prettier code style)

✅ Lint Go: Ran make lint - 0 issues found

✅ Lint JS: JavaScript already formatted and linted - all files validated

✅ Review changes: Code review completed - no comments

✅ Add tests for helpers: Enhanced repo_helpers.test.cjs with 2 additional tests for getDefaultTargetRepo config parameter handling (commit 8a8654d)

All 20 tests passing for repo_helpers module covering parseAllowedRepos, getDefaultTargetRepo, validateRepo, and parseRepoSlug functions.

pelikhan · 2026-01-04T04:57:43Z

@copilot review changes, lint go, lint js

pelikhan · 2026-01-04T05:01:18Z

actions/setup/js/add_comment.cjs

+    const itemRepo = item.repo ? String(item.repo).trim() : defaultTargetRepo;
+
+    // Validate the repository is allowed
+    const repoValidation = validateRepo(itemRepo, defaultTargetRepo, allowedRepos);
+    if (!repoValidation.valid) {
+      core.warning(`Skipping comment: ${repoValidation.error}`);
+      return {
+        success: false,
+        error: repoValidation.error,
+      };
+    }
+
+    // Parse the repository slug
+    const repoParts = parseRepoSlug(itemRepo);
+    if (!repoParts) {
+      const error = `Invalid repository format '${itemRepo}'. Expected 'owner/repo'.`;
+      core.warning(`Skipping comment: ${error}`);
+      return {
+        success: false,
+        error,
+      };
+    }
+
+    core.info(`Target repository: ${itemRepo}`);


@copilot refactor into helper

Refactored into resolveAndValidateRepo() helper function (commit 4461505).

Changes:

Created new helper in repo_helpers.cjs that combines repo resolution, validation, and parsing

Updated add_comment.cjs, create_pr_review_comment.cjs, and create_pull_request.cjs to use the helper

Eliminated ~60 lines of duplicated code across the three handlers

Added 5 comprehensive tests for the new helper function

All tests passing (30/30 for repo functionality).

Co-authored-by: pelikhan <[email protected]>

Copilot · 2026-01-04T05:06:36Z

@copilot only generate the "repo" tool argument if the allowed-repos configuration has entries. Otherwise, it is not needed when defining the tool in the safe output mcp server.

Implemented conditional repo parameter generation. The parameter is now only added to the tool inputSchema when allowed-repos has entries (commit ca880ac).

Changes:

Added addRepoParameterIfNeeded() function that checks for non-empty allowed-repos configuration
Only tools with allowed-repos entries get the repo parameter in their schema
Tools without allowed-repos maintain clean schemas without the unnecessary parameter

Tests added:

5 comprehensive tests verify correct behavior for various scenarios
Tests confirm parameter is added only when needed
All existing and new tests passing (workflow tests + repo parameter tests)

Co-authored-by: pelikhan <[email protected]>

Copilot · 2026-01-04T05:18:58Z

@copilot review changes, lint go, lint js

Completed all requested tasks:

✅ Review changes: Code review completed - no issues found

✅ Lint Go: Go code formatted with gofmt - all files valid

✅ Lint JS: JavaScript formatted and linted with Prettier - all files use Prettier code style

Additional improvements made:

Refactored duplicated repo validation logic into reusable helper (commit 4461505)
Added 5 tests for new resolveAndValidateRepo() helper
All 30 tests passing for repo functionality

actions/setup/js/add_comment.cjs

pelikhan · 2026-01-04T05:27:33Z

actions/setup/js/add_comment.cjs

 const { getTrackerID } = require("./get_tracker_id.cjs");
 const { getErrorMessage } = require("./error_helpers.cjs");
 const { resolveTarget } = require("./safe_output_helpers.cjs");
+const { parseAllowedRepos, getDefaultTargetRepo, resolveAndValidateRepo } = require("./repo_helpers.cjs");


@copilot create helper that resolves the target repo from the config and the tool arguments

Created resolveTargetRepoConfig() helper function (commit 68fa2fe).

Implementation:

Combines parseAllowedRepos() and getDefaultTargetRepo() into a single helper

Returns {defaultTargetRepo, allowedRepos} for use in handlers

Simplifies initialization from 2 function calls to 1

Usage:

const { defaultTargetRepo, allowedRepos } = resolveTargetRepoConfig(config);

Updates:

Applied to add_comment.cjs, create_pr_review_comment.cjs, create_pull_request.cjs

Added 4 comprehensive tests for various config scenarios

All 34 tests passing

Co-authored-by: pelikhan <[email protected]>

pelikhan · 2026-01-04T05:40:47Z

@copilot update JSON schemas

Co-authored-by: pelikhan <[email protected]>

Copilot · 2026-01-04T05:48:31Z

@copilot update JSON schemas

Updated JSON schemas with allowed-repos field (commit ef3e1b7).

Changes to pkg/parser/schemas/main_workflow_schema.json:

Added allowed-repos array field to 4 safe output types:
- add-comment
- create-pull-request
- create-pull-request-review-comment
- create-agent-task
create-issue and create-discussion already had the field

Schema definition:

"allowed-repos": {
  "type": "array",
  "items": {"type": "string"},
  "description": "List of additional repositories in format 'owner/repo'..."
}

All 6 safe output types now have complete schema support. Binary rebuilt with embedded schemas. Parser tests passing.

pelikhan · 2026-01-04T05:51:31Z

@copilot also update imported JSON schema

Co-authored-by: pelikhan <[email protected]>

pelikhan · 2026-01-04T06:29:18Z

@copilot keep working

Copilot · 2026-01-04T06:32:54Z

@copilot keep working

Updated .github/aw/main_workflow_schema.json with allowed-repos field (commit ee49feb).

Changes:

Added allowed-repos array field to all 4 safe output types that were missing it:
- add-comment
- create-pull-request
- create-pull-request-review-comment
- create-agent-task

All 6 safe output types now have complete allowed-repos support in both schema files:

✅ pkg/parser/schemas/main_workflow_schema.json (used by Go binary)
✅ .github/aw/main_workflow_schema.json (imported/published schema)

Schema validated. JavaScript linted and formatted.

Initial plan

d4c370b

Copilot AI assigned Copilot and pelikhan Jan 4, 2026

Copilot started work on behalf of pelikhan January 4, 2026 04:17 View session

Copilot AI and others added 4 commits January 4, 2026 04:29

Add allowed-repos field to safe output config types

649f837

Co-authored-by: pelikhan <[email protected]>

Update add_comment.cjs to support repo argument and allowed-repos val…

223d76e

…idation Co-authored-by: pelikhan <[email protected]>

Update create_pr_review_comment.cjs to support repo argument and allo…

0067385

…wed-repos validation Co-authored-by: pelikhan <[email protected]>

Update create_pull_request.cjs to support repo argument and allowed-r…

48e1793

…epos validation Co-authored-by: pelikhan <[email protected]>

Copilot AI changed the title ~~[WIP] Add allowed-repos field to safe output types~~ Add allowed-repos field to safe output types for cross-repository operations Jan 4, 2026

Copilot AI requested a review from pelikhan January 4, 2026 04:46

Copilot finished work on behalf of pelikhan January 4, 2026 04:46

Copilot started work on behalf of pelikhan January 4, 2026 04:48 View session

Add tests for config parameter in getDefaultTargetRepo

8a8654d

Co-authored-by: pelikhan <[email protected]>

Copilot finished work on behalf of pelikhan January 4, 2026 04:57

Copilot started work on behalf of pelikhan January 4, 2026 04:57 View session

pelikhan reviewed Jan 4, 2026

View reviewed changes

Only add repo parameter to tool schema when allowed-repos has entries

ca880ac

Co-authored-by: pelikhan <[email protected]>

Copilot AI requested a review from pelikhan January 4, 2026 05:11

Copilot finished work on behalf of pelikhan January 4, 2026 05:11

Copilot started work on behalf of pelikhan January 4, 2026 05:11 View session

Refactor repo validation into reusable helper function

4461505

Co-authored-by: pelikhan <[email protected]>

Copilot finished work on behalf of pelikhan January 4, 2026 05:20

pelikhan reviewed Jan 4, 2026

View reviewed changes

actions/setup/js/add_comment.cjs Outdated Show resolved Hide resolved

Copilot started work on behalf of pelikhan January 4, 2026 05:22 View session

Copilot AI requested a review from pelikhan January 4, 2026 05:24

Copilot finished work on behalf of pelikhan January 4, 2026 05:24

pelikhan reviewed Jan 4, 2026

View reviewed changes

Copilot started work on behalf of pelikhan January 4, 2026 05:28 View session

Add resolveTargetRepoConfig helper to simplify config initialization

68fa2fe

Co-authored-by: pelikhan <[email protected]>

Copilot AI requested a review from pelikhan January 4, 2026 05:35

Copilot finished work on behalf of pelikhan January 4, 2026 05:35

Copilot started work on behalf of pelikhan January 4, 2026 05:41 View session

Add allowed-repos field to JSON schemas for all safe output types

ef3e1b7

Co-authored-by: pelikhan <[email protected]>

Copilot finished work on behalf of pelikhan January 4, 2026 05:49

Copilot started work on behalf of pelikhan January 4, 2026 05:52 View session

Changes before error encountered

ee49feb

Co-authored-by: pelikhan <[email protected]>

Copilot started work on behalf of pelikhan January 4, 2026 06:29 View session

pelikhan marked this pull request as ready for review January 4, 2026 06:34

Copilot finished work on behalf of pelikhan January 4, 2026 06:34

pelikhan merged commit 05c9fb6 into main Jan 4, 2026
86 of 90 checks passed

pelikhan deleted the copilot/add-allowed-repos-field branch January 4, 2026 06:35

Add allowed-repos field to safe output types for cross-repository operations #8837

Add allowed-repos field to safe output types for cross-repository operations #8837

Uh oh!

Conversation

Copilot AI commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Complete: Add allowed-repos field to safe output types

Summary

Implementation Complete

MCP Tool Schema Enhancement

Code Quality Improvements

Safe Output Types with allowed-repos Support

Quality Checks Completed

Uh oh!

pelikhan commented Jan 4, 2026

Uh oh!

pelikhan commented Jan 4, 2026

Uh oh!

Copilot AI commented Jan 4, 2026

Uh oh!

pelikhan commented Jan 4, 2026

Uh oh!

pelikhan Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 4, 2026

Uh oh!

Copilot AI commented Jan 4, 2026

Uh oh!

Uh oh!

pelikhan Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Jan 4, 2026

Uh oh!

Copilot AI commented Jan 4, 2026

Uh oh!

pelikhan commented Jan 4, 2026

Uh oh!

pelikhan commented Jan 4, 2026

Uh oh!

Copilot AI commented Jan 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 4, 2026 •

edited

Loading