fix: resolve linting errors in test files#8672
Merged
mnkiefer merged 2 commits intoupdate-campaign-logicfrom Jan 2, 2026
Merged
fix: resolve linting errors in test files#8672mnkiefer merged 2 commits intoupdate-campaign-logicfrom
mnkiefer merged 2 commits intoupdate-campaign-logicfrom
Conversation
- Changed assert.NoError to require.NoError in interfaces_test.go - Removed unused imports in test files - Fixed whitespace alignment in multiple test files - Removed extra blank line in status_command.go Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update campaign management with new validation and documentation
fix: resolve linting errors in test files
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codebase had linting errors from using
assert.NoErrorinstead ofrequire.NoErrorfor error assertions in test setup code, plus minor formatting inconsistencies.Changes
Test assertions: Changed
assert.NoErrortorequire.NoErrorinpkg/cli/interfaces_test.gofor shell completion generation tests. Usingrequireis correct here since these are setup operations where continuation after failure is meaningless.Formatting cleanup: Removed unused
contextimports, aligned struct field whitespace, removed extraneous blank lines.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.